Skip to content

[ci] Remove jcenter from legacy project #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jun 26, 2023

The checked in legacy Android project used for compat testing accidentally re-introduced a jcenter depedency into the repo. Since that has server implications, we shouldn't be using it; this updates the legacy package to replace jcenter with mavenCentral, as we did a while ago in all of our packages and templates.

Fixes flutter/flutter#129467

The checked in legacy Android project used for compat testing
accidentally re-introduced a `jcenter` depedency into the repo. Since
that has server implications, we shouldn't be using it; this updates the
legacy package to replace `jcenter` with `mavenCentral`, as we did a
while ago in all of our packages and templates.

Fixes(?) flutter/flutter#129467
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor Author

Landing on red to re-open the tree. (Not all tests have passed here, but the only ones that directory is used by have, and the tree has already been closed for quite a while.)

@stuartmorgan-g stuartmorgan-g merged commit 05efbb2 into flutter:main Jun 26, 2023
@stuartmorgan-g stuartmorgan-g deleted the legacy-build-all-remove-jcenter branch June 26, 2023 15:51
@ditman
Copy link
Member

ditman commented Jun 26, 2023

Oh my, I totally had forgotten about the jcenter migration (and didn't notice it in this build task!)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jun 27, 2023
flutter/packages@6b70804...f89ce02

2023-06-27 hansmuller@google.com Updated
rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316)
2023-06-27 tarrinneal@gmail.com [shared_preferences] Adds new
`clearWithParameters` and `getAllWithParameters` methods to platform
interface. (flutter/packages#4261)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter from
042c036 to 96a2c05 (60 revisions) (flutter/packages#4313)
2023-06-26 10687576+bparrishMines@users.noreply.github.com
[file_selector_android] Create initial Android implementation of the
file_selector package (flutter/packages#3814)
2023-06-26 49699333+dependabot[bot]@users.noreply.github.com
[in_app_pur]: Bump org.json:json from 20230227 to 20230618 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#4244)
2023-06-26 me@ghyeok.io [webview_flutter_wkwebview] Adds the
`isInspectable` to `WebKitWebViewController`. (flutter/packages#3984)
2023-06-26 stuartmorgan@google.com [ci] Remove jcenter from legacy
project (flutter/packages#4306)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux_android android_build_all_packages master failing (consistently?)
3 participants