Skip to content

[go_router] fix error handling page link #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 20, 2023
Merged

[go_router] fix error handling page link #4296

merged 6 commits into from
Jul 20, 2023

Conversation

utamori
Copy link
Contributor

@utamori utamori commented Jun 25, 2023 •
edited
Loading

I have corrected the link to the document, as it was incorrect.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@utamori utamori requested a review from chunhtai as a code owner June 25, 2023 09:25
@utamori utamori changed the title fix error handling page link ［go_router］fix error handling page link Jun 25, 2023
chunhtai
chunhtai approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you update the changelog and bump version? it would require a new version for the doc to propagate.

@chunhtai chunhtai requested a review from johnpryan June 26, 2023 15:58
@johnpryan johnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 26, 2023

auto label is removed for flutter/packages, pr: 4296, due to - The status or check suite Linux_android android_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@johnpryan johnpryan added autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes labels Jun 26, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 26, 2023

auto label is removed for flutter/packages, pr: 4296, due to - The status or check suite Linux_android android_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai
Copy link
Contributor

For this one, we may want to bump the package version.

@utamori utamori changed the title ［go_router］fix error handling page link [go_router] fix error handling page link Jun 27, 2023
@utamori utamori requested a review from chunhtai June 27, 2023 11:03
chunhtai
chunhtai approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 27, 2023

auto label is removed for flutter/packages, pr: 4296, due to - The status or check suite Linux_android android_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2023
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 27, 2023

auto label is removed for flutter/packages, pr: 4296, due to - The status or check suite Linux_web web_build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai
Copy link
Contributor

chunhtai commented Jul 6, 2023

Hi @utamori can you resolve the conflict?

@utamori
Copy link
Contributor Author

utamori commented Jul 8, 2023

@chunhtai
done

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 10, 2023

auto label is removed for flutter/packages, pr: 4296, due to Pull request flutter/packages/4296 is not in a mergeable state.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 10, 2023

auto label is removed for flutter/packages, pr: 4296, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@johnpryan johnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 11, 2023

auto label is removed for flutter/packages, pr: 4296, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai
Copy link
Contributor

for some reason this pr slip through the crack. @utamori can you rebase and fix the version and changelog?

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2023
@auto-submit auto-submit bot merged commit a9731f2 into flutter:main Jul 20, 2023
@utamori
Copy link
Contributor Author

utamori commented Jul 20, 2023

@chunhtai thank you！

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
a9731f2 [go_router] fix error handling page link (flutter/packages#4296)
4eb99cd
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
Roll Packages from 674179f to 2266a76 (6 revisions) (#131058)
9cfbf6b 
flutter/packages@674179f...2266a76

2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525)
2023-07-20 34871572+gmackall@users.noreply.github.com [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535)
2023-07-20 59682979+utamori@users.noreply.github.com [go_router] fix error handling page link (flutter/packages#4296)
2023-07-20 stuartmorgan@google.com [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534)
2023-07-20 stuartmorgan@google.com [ci] Simplify Dockerfile (flutter/packages#4530)
2023-07-20 stuartmorgan@google.com [ci] Enable Windows Dart unit test sharding (flutter/packages#4528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from 674179f to 2266a76 (6 revisions) (flutter#131058)
f00e80f 
flutter/packages@674179f...2266a76

2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525)
2023-07-20 34871572+gmackall@users.noreply.github.com [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535)
2023-07-20 59682979+utamori@users.noreply.github.com [go_router] fix error handling page link (flutter/packages#4296)
2023-07-20 stuartmorgan@google.com [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534)
2023-07-20 stuartmorgan@google.com [ci] Simplify Dockerfile (flutter/packages#4530)
2023-07-20 stuartmorgan@google.com [ci] Enable Windows Dart unit test sharding (flutter/packages#4528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan johnpryan approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utamori @chunhtai @johnpryan