[multiple packages] Update collection-fors to prefer final (as per updated prefer_final_in_for_each)
#4073
Conversation
pq
requested review from
cyanglaz,
gmackall,
yjbanov,
chunhtai and
domesticmouse
as code owners
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
pq
changed the title
prefer_final_in_for_each)prefer_final_in_for_each)
|
test-exempt: lint update |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages, pr: 4073, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Thanks @gmackall! Formatting fixed but I wonder if you could add the |
|
I know that changes to ignored lints are version exempt, but I'm actually not sure about changes that are for broken but soon-to-be fixed lints. cc'ing @stuartmorgan, do you happen to know? |
stuartmorgan-g
added
override: no versioning needed
|
Usually we don't exempt code changes, even if it's to fix lints, because just because the intent of the change was to fix a lint doesn't mean the effect of the change won't be to actually change behavior in some subtle way. I have seen (and been responsible for) plenty of cases where a change whose description says "does not change behavior" has to be rolled back because it did in fact change behavior. In general, err on the side of bumping versions for that reason. In this case though, we can have a high enough degree of confidence that it can't break anything—I would not expect this to even change the generated code at all—to skip having it in its own release. |
|
Thanks @stuartmorgan! |
…s per updated `prefer_final_in_for_each`) (flutter/packages#4073)
flutter/packages@995bfc5...9f8dcc5 2023-05-25 54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/packages#4074) 2023-05-25 10687576+bparrishMines@users.noreply.github.com [url_launcher_android] Fix `unawaited_futures` lint errors (flutter/packages#4086) 2023-05-25 stuartmorgan@google.com [url_launcher] Convert Android to Pigeon (flutter/packages#4045) 2023-05-25 pq@users.noreply.github.com [multiple packages] Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (flutter/packages#4073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The newly updated lint will soon flag for-each in collections.
See discussion: dart-archive/linter#4383
/cc @goderbauer @yjbanov
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.