-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[go_router] fix context extension for replaceNamed #3927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b2c1548
fix context extension for replaceNamed
Dreamersoul db8f491
formatting fixed
Dreamersoul e3466e5
bump version
Dreamersoul 92bdd7d
added changelog
Dreamersoul c275a81
fix formatting
Dreamersoul 74725ab
added tests
Dreamersoul 9c0851a
Update CHANGELOG.md
Dreamersoul b905859
add query parameters to the test case
Dreamersoul fa8e5d5
Merge branch 'main' into patch-1
Dreamersoul 4ee22ae
bump up pubspec.yaml
Dreamersoul 78239db
Update CHANGELOG.md formatting
Dreamersoul d6a5db1
Update packages/go_router/CHANGELOG.md
Dreamersoul 8f680d5
Merge branch 'main' into patch-1
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'package:flutter/material.dart'; | ||
import 'package:flutter_test/flutter_test.dart'; | ||
import 'package:go_router/go_router.dart'; | ||
|
||
void main() { | ||
group('replaceNamed', () { | ||
Future<GoRouter> createGoRouter( | ||
WidgetTester tester, { | ||
Listenable? refreshListenable, | ||
}) async { | ||
final GoRouter router = GoRouter( | ||
initialLocation: '/', | ||
routes: <GoRoute>[ | ||
GoRoute( | ||
path: '/', | ||
name: 'home', | ||
builder: (_, __) => const _MyWidget(), | ||
), | ||
GoRoute( | ||
path: '/page-0/:tab', | ||
name: 'page-0', | ||
builder: (_, __) => const SizedBox()) | ||
], | ||
); | ||
await tester.pumpWidget(MaterialApp.router( | ||
routerConfig: router, | ||
)); | ||
return router; | ||
} | ||
|
||
testWidgets('Passes GoRouter parameters through context call.', | ||
(WidgetTester tester) async { | ||
final GoRouter router = await createGoRouter(tester); | ||
await tester.tap(find.text('Settings')); | ||
await tester.pumpAndSettle(); | ||
expect(router.location, '/page-0/settings?search=notification'); | ||
}); | ||
}); | ||
} | ||
|
||
class _MyWidget extends StatelessWidget { | ||
const _MyWidget(); | ||
|
||
@override | ||
Widget build(BuildContext context) { | ||
return ElevatedButton( | ||
onPressed: () => context.replaceNamed('page-0', | ||
pathParameters: <String, String>{'tab': 'settings'}, | ||
queryParameters: <String, String>{'search': 'notification'}), | ||
child: const Text('Settings')); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.