Skip to content

[camera_android] Provides a default exposure point if null. #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Jul 27, 2023
Merged

[camera_android] Provides a default exposure point if null. #3851

merged 40 commits into from
Jul 27, 2023

Conversation

Mairramer
Copy link
Contributor

Recently we had problems in our apps (they use the camera a lot), due to the error of [CONTROL_AE_REGIONS] being set to a null value.

It should now return the default exposure point value. Thanks https://github.com/AnggaSP

Fix attempt for flutter/flutter#105200

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Mairramer Mairramer requested a review from camsim99 as a code owner April 29, 2023 13:58
@Mairramer Mairramer mentioned this pull request Apr 29, 2023
Closed
11 tasks
@stuartmorgan-g stuartmorgan-g requested a review from camsim99 May 16, 2023 20:04
Mairramer added 3 commits May 30, 2023 09:36
@Mairramer
[camera_android] added method to create default exposure
b531c28
@Mairramer
Merge branch 'main' into camera_exposure_fix
09865ad 
# Conflicts:
#	packages/camera/camera_android/CHANGELOG.md
#	packages/camera/camera_android/pubspec.yaml
@Mairramer
nullable annotation
ceec022
@Mairramer Mairramer requested a review from camsim99 May 30, 2023 13:33
@Mairramer Mairramer requested a review from camsim99 June 5, 2023 16:38
camsim99
camsim99 requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Just some nits, versioning comments, and a suggestion for the type of error to throw.

@Mairramer Mairramer requested a review from bparrishMines July 18, 2023 19:14
@Mairramer Mairramer requested a review from bparrishMines July 19, 2023 16:20
@Mairramer Mairramer requested a review from camsim99 July 24, 2023 16:41
@Mairramer Mairramer requested a review from camsim99 July 26, 2023 21:31
bparrishMines
bparrishMines approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

camsim99
camsim99 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2023
@auto-submit auto-submit bot merged commit 867f2a4 into flutter:main Jul 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2023
@engine-flutter-autoroll
867f2a4 [camera_android] Provides a default exposure point if null. (f…
962014d 
…lutter/packages#3851)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 28, 2023
@engine-flutter-autoroll
Roll Packages from f4ae933 to 10aab44 (4 revisions) (#131483)
6b6f5f0 
flutter/packages@f4ae933...10aab44

2023-07-28 tarrinneal@gmail.com remove unneeded imports (flutter/packages#4579)
2023-07-27 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 50643541+Mairramer@users.noreply.github.com [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter from 61fd11d to dd9764e (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from f4ae933 to 10aab44 (4 revisions) (flutter#131483)
6a7d5ca 
flutter/packages@f4ae933...10aab44

2023-07-28 tarrinneal@gmail.com remove unneeded imports (flutter/packages#4579)
2023-07-27 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 50643541+Mairramer@users.noreply.github.com [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter from 61fd11d to dd9764e (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll @vashworth
Roll Packages from f4ae933 to 10aab44 (4 revisions) (flutter#131483)
2d90491 
flutter/packages@f4ae933...10aab44

2023-07-28 tarrinneal@gmail.com remove unneeded imports (flutter/packages#4579)
2023-07-27 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 50643541+Mairramer@users.noreply.github.com [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter from 61fd11d to dd9764e (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

@camsim99 camsim99 camsim99 approved these changes

@gmackall gmackall Awaiting requested review from gmackall

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mairramer @davidmartos96 @camsim99 @gmackall @bparrishMines @reidbaker