[various] Speed up build-examples #3849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and had an android config
reidbaker
requested review from
camsim99,
gmackall,
bparrishMines,
tarrinneal,
stuartmorgan-g,
gspencergoog,
chunhtai,
domesticmouse,
ditman,
Piinks and
goderbauer
as code owners
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tarrinneal
approved these changes
Apr 28, 2023
Piinks
reviewed
Apr 28, 2023
|
Test exemption requested https://discord.com/channels/608014603317936148/608021234516754444/1102644603594739722 |
reidbaker
commented
May 1, 2023
|
test exemption should not be necessary, the PR modifies a test |
Sorry test modification added after the request was sent. |
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2023
flutter/packages@de6131d...f163786 2023-05-01 43054281+camsim99@users.noreply.github.com [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798) 2023-05-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) (flutter/packages#3874) 2023-05-01 vashworth@google.com [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873) 2023-05-01 reidbaker@google.com [various] Speed up build-examples (flutter/packages#3849) 2023-05-01 stuartmorgan@google.com [file_selector] Remove uses of `macUTIs` (flutter/packages#3859) 2023-05-01 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter#125707 - Create pluginTools config for every example that shrunk material icons and had an android config Likely some build caching but before/after If someone knows how to clean the cache or force a rebuild I will give more accurate after numbers. Command `time dart run ./script/tool/bin/flutter_plugin_tools.dart build-examples --apk` Secondary validation from @stuartmorgan who discovered this is between a 10% and 25% speed increase. Existing tests add confidence this is non-breaking. New tests not required because these are optional flags. Validation this does not change is low consequence. Test update to exclude these config files from changelog requirements.
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#125707
Likely some build caching but before/after If someone knows how to clean the cache or force a rebuild I will give more accurate after numbers.
Command
time dart run ./script/tool/bin/flutter_plugin_tools.dart build-examples --apkSecondary validation from @stuartmorgan who discovered this is between a 10% and 25% speed increase.
Existing tests add confidence this is non-breaking. New tests not required because these are optional flags. Validation this does not change is low consequence. Test update to exclude these config files from changelog requirements.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).