Skip to content

[various] Enable warnings as errors, and all warnings, for Android lint #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 7, 2023
Merged

[various] Enable warnings as errors, and all warnings, for Android lint #3648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e54d7f3
Enable all warnings and warnings as errors in all plugins
stuartmorgan-g Apr 5, 2023
03dd9ca
New baselines
stuartmorgan-g Apr 5, 2023
0fed722
Add a missed InvalidPackage suppression
stuartmorgan-g Apr 5, 2023
af01e52
revert accidental changes
stuartmorgan-g Apr 5, 2023
1f880d8
Add tooling check for new config
stuartmorgan-g Apr 6, 2023
47aaaa8
Merge branch 'main' into android-lint-werror
stuartmorgan-g Apr 7, 2023
06e9068
Baseline update
stuartmorgan-g Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/camera/camera_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ android {
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions {
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
baseline file("lint-baseline.xml")
}
Expand Down
3,126 changes: 3,059 additions & 67 deletions packages/camera/camera_android/android/lint-baseline.xml
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions packages/camera/camera_android_camerax/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ android {
}

lintOptions {
disable 'AndroidGradlePluginVersion'
disable 'GradleDependency'
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'GradleDependency', 'InvalidPackage'
baseline file("lint-baseline.xml")
}
}

Expand Down
1,434 changes: 1,434 additions & 0 deletions packages/camera/camera_android_camerax/android/lint-baseline.xml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions packages/espresso/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ android {
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions {
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
baseline file("lint-baseline.xml")
}
Expand Down
2,453 changes: 2,244 additions & 209 deletions packages/espresso/android/lint-baseline.xml
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions packages/flutter_plugin_android_lifecycle/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ android {
consumerProguardFiles 'proguard.txt'
}
lintOptions {
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
baseline file("lint-baseline.xml")
}

dependencies {
Expand Down
15 changes: 15 additions & 0 deletions packages/flutter_plugin_android_lifecycle/android/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations"
errorLine1=" public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/flutter_plugin_android_lifecycle/FlutterAndroidLifecyclePlugin.java"
line="18"
column="35"/>
</issue>

</issues>
3 changes: 3 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ android {
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions {
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
baseline file("lint-baseline.xml")
}

dependencies {
Expand Down
202 changes: 202 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_android/android/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,202 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 7.0.1" type="baseline" client="gradle" name="AGP (7.0.1)" variant="all" version="7.0.1">

<issue
id="SyntheticAccessor"
message="Access to `private` field `loadedCallbackPending` of class `GoogleMapController` requires synthetic accessor"
errorLine1=" loadedCallbackPending = false;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java"
line="165"
column="13"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` method `postFrameCallback` of class `GoogleMapController` requires synthetic accessor"
errorLine1=" postFrameCallback("
errorLine2=" ~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java"
line="166"
column="13"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` method `postFrameCallback` of class `GoogleMapController` requires synthetic accessor"
errorLine1=" postFrameCallback("
errorLine2=" ~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java"
line="168"
column="19"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` field `mapView` of class `GoogleMapController` requires synthetic accessor"
errorLine1=" if (mapView != null) {"
errorLine2=" ~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java"
line="170"
column="29"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` field `mapView` of class `GoogleMapController` requires synthetic accessor"
errorLine1=" mapView.invalidate();"
errorLine2=" ~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java"
line="171"
column="27"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` constructor of class `ProxyLifecycleProvider` requires synthetic accessor"
errorLine1=" new ProxyLifecycleProvider(activity)));"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="64"
column="19"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` field `lifecycle` of class `GoogleMapsPlugin` requires synthetic accessor"
errorLine1=" return lifecycle;"
errorLine2=" ~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="85"
column="28"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` field `handler` of class `TileProviderController` requires synthetic accessor"
errorLine1=" handler.post("
errorLine2=" ~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/TileProviderController.java"
line="52"
column="7"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` field `methodChannel` of class `TileProviderController` requires synthetic accessor"
errorLine1=" methodChannel.invokeMethod("
errorLine2=" ~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/TileProviderController.java"
line="54"
column="15"/>
</issue>

<issue
id="SyntheticAccessor"
message="Access to `private` field `tileOverlayId` of class `TileProviderController` requires synthetic accessor"
errorLine1=" Convert.tileOverlayArgumentsToJson(tileOverlayId, x, y, zoom),"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/TileProviderController.java"
line="56"
column="54"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public PlatformView create(Context context, int id, Object args) {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapFactory.java"
line="33"
column="10"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public PlatformView create(Context context, int id, Object args) {"
errorLine2=" ~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapFactory.java"
line="33"
column="30"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public PlatformView create(Context context, int id, Object args) {"
errorLine2=" ~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapFactory.java"
line="33"
column="55"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" final io.flutter.plugin.common.PluginRegistry.Registrar registrar) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="35"
column="13"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public void onAttachedToEngine(FlutterPluginBinding binding) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="73"
column="34"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public void onDetachedFromEngine(FlutterPluginBinding binding) {}"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="91"
column="36"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public void onAttachedToActivity(ActivityPluginBinding binding) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="96"
column="36"/>
</issue>

<issue
id="UnknownNullness"
message="Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://android.github.io/kotlin-guides/interop.html#nullability-annotations"
errorLine1=" public void onReattachedToActivityForConfigChanges(ActivityPluginBinding binding) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java"
line="106"
column="54"/>
</issue>

</issues>
3 changes: 3 additions & 0 deletions packages/google_sign_in/google_sign_in_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ android {
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions {
checkAllWarnings true
warningsAsErrors true
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
baseline file("lint-baseline.xml")
}


Expand Down
Loading