Skip to content

Conversation

@ditman
Copy link
Member

@ditman ditman commented Apr 3, 2023

Introduces: canAccessScopes method and userDataEvents stream to the platform_interface of the google_sign_in plugin.

Default implementations:

  • canAccessScopes => throw not implemented.
  • userDataEvents => null (currently user data events cannot be introduced asynchronously from the native side)

The changes above enable the separation of Authentication and Authorization, and asynchronous sign-in operations as needed (the web needs this now).

Issues

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g as a code owner April 3, 2023 20:51
@ditman ditman changed the title [google_sign_in_platform_interface] Introduces canAccessScopes and userDataEvents. [gsi_interface] Introduces canAccessScopes and userDataEvents. Apr 3, 2023
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@ditman
Copy link
Member Author

ditman commented Apr 4, 2023

Triggering a branch update to see if the "Windows" checks get unstuck.

@ditman ditman force-pushed the gsi-button-interface branch from 44c1cfd to 1d7c921 Compare April 4, 2023 21:18
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 4, 2023

auto label is removed for flutter/packages, pr: 3635, due to - The status or check suite Linux plugin_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@ditman
Copy link
Member Author

ditman commented Apr 5, 2023

My dearest autosubmit bot, please take a look at this PR :')

@ditman ditman added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 5, 2023
@auto-submit auto-submit bot merged commit 875d249 into flutter:main Apr 5, 2023
@ditman ditman deleted the gsi-button-interface branch April 5, 2023 04:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…er#3635)

[gsi_interface] Introduces canAccessScopes and userDataEvents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants