Skip to content

Removed the Directionality widget in the adaptive scaffold to support… #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Removed the Directionality widget in the adaptive scaffold to support… #3602

wants to merge 3 commits into from

Conversation

samanzamani
Copy link

@samanzamani samanzamani commented Mar 31, 2023 •
edited by stuartmorgan-g
Loading

Remove the Directionality widget in suppose to support RTL language.

  • support RTL languages

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Mar 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template (or subsets of it); it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored the full checklist to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft April 11, 2023 19:48
@stuartmorgan-g
Copy link
Contributor

Since this is marked as a draft and hasn't been updated in the last month I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!

@ahmednfwela ahmednfwela mentioned this pull request Jun 13, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Jun 14, 2023
@ahmednfwela
[flutter_adaptive_scaffold] Support RTL (#4204)
b7f1ad4 
This PR removes the hardcoded rtl directionality placed on top of `AdaptiveScaffold` for an unknown reason.

| RTL | LTR |
|-----|-----|
| ![image](https://github.com/flutter/packages/assets/63286031/10adac59-3f9a-4f4d-85da-939efbb47ae8)  |  ![image](https://github.com/flutter/packages/assets/63286031/c8c1af75-4787-473c-a397-a64d2f9b1e88)  |

## Changes in this PR

- Core: Removed this hardcoded `Directionality` widget https://github.com/flutter/packages/blob/050729760b251e315af01876cc7d7de5dcfba0e9/packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart#L491-L494
- Core: Added tests to ensure text direction is passed correctly
- Core: Modified `example/adaptive_scaffold_demo.dart` to demonstrate support for RTL
- Side: There were some tests that were getting skipped, I have enabled them since their related issues landed on stable.
- Side: Stopped ignoring `prefer_const_constructors` since it landed in stable as well.

I made the commit messages as descriptive as possible so that it's easier to review relevant changes.

## Related issues
- Supersedes #3602 
- Fixes flutter/flutter#119661

Question for reviewers: should the next version be 0.1.5 or 0.2.0 ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees
No one assigned
Labels
needs tests p: flutter_adaptive_scaffold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samanzamani @stuartmorgan-g