[image_picker][android] Non-bitmap images now return path instead of null #3590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
andreisas06
changed the title
|
Thanks for the contribution! It looks like the tests you added currently are failing to run, if you can get that sorted then we can get this fully reviewed. Also ccing @tarrinneal for image picker related PR visibility. |
andreisas06
changed the title
stuartmorgan-g
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
LGTM with CHANGELOG nits! @gmackall or @tarrinneal could you do the secondary review?
|
|
||
| * Example file showcases how to display an error placeholder whenever an unsupported image type is selected. |
There was a problem hiding this comment.
We generally describe the change with a verb. E.g., "Adds handling of unsupported image types to the example."
|
|
||
| * Non-bitmap images return path instead of null. |
There was a problem hiding this comment.
"Fixes handling of non-bitmap image types."
There was a problem hiding this comment.
Updated the PR with the changes, thank you for the review 🙏🏻.
tarrinneal
approved these changes
Apr 13, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2023
flutter/packages@e4ec155...0277f2a 2023-04-16 engine-flutter-autoroll@skia.org Roll Flutter from 00171b0 to 50171bb (7 revisions) (flutter/packages#3723) 2023-04-15 engine-flutter-autoroll@skia.org Roll Flutter from f740544 to 00171b0 (17 revisions) (flutter/packages#3717) 2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.9 to 2.2.12 (flutter/packages#3711) 2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/packages#3710) 2023-04-14 stuartmorgan@google.com [path_provider] Fix Android lint warnings (flutter/packages#3706) 2023-04-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [camera_android_camerax] Updates internal Java InstanceManager to only stop finalization callbacks when stopped (flutter/packages#3571) 2023-04-14 stuartmorgan@google.com [shared_preferences] Fix Android Java version issue (flutter/packages#3712) 2023-04-14 48185017+andreisas06@users.noreply.github.com [image_picker][android] Non-bitmap images now return path instead of null (flutter/packages#3590) 2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter from be45eb2 to f740544 (24 revisions) (flutter/packages#3713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…null (flutter#3590) ## Description This PR now returns the path of unsupported files(non-bitmap images) instead of null. Now the user can decide himself what to do with the path of the unsupported image. Example file showcases how to display an error placeholder whenever an unsupported image type is selected. ## Issues Fixes flutter/flutter#88461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR now returns the path of unsupported files(non-bitmap images) instead of null. Now the user can decide himself what to do with the path of the unsupported image. Example file showcases how to display an error placeholder whenever an unsupported image type is selected.
Issues
Fixes flutter/flutter#88461
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).