Skip to content

Update webview_flutter_wkwebview to newer pigeon #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

natebosch
Copy link
Contributor

@natebosch natebosch commented Mar 27, 2023

The current version is incompatible with the latest analyzer, which is a blocker for getting the latest mockito, which is a blocker for getting the latest test_api, which is pinned by flutter_test and will be breaking in the next package roll.

Roll to version 7.0.5 to avoid breaking changes in newer versions.

The current version is incompatible with the latest `analyzer`, which is
a blocker for getting the latest `mockito`, which is a blocker for
getting the latest `test_api`, which is pinned by `flutter_test` and
will be breaking in the next package roll.
@natebosch natebosch requested a review from cyanglaz as a code owner March 27, 2023 18:28
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@natebosch natebosch changed the title Update webview_flutter_wkwebview to latest pigeon Update webview_flutter_wkwebview to newer pigeon Mar 27, 2023
@Hixie
Copy link
Contributor

Hixie commented Mar 27, 2023

test-exempt: dependency roll

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

There was a const construction issue that wasn't fixed until a later breaking change, but extracting the copyright to a single file (as we do in most packages now) avoided it.

@natebosch natebosch added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit auto-submit bot merged commit f14934c into flutter:main Mar 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@natebosch natebosch deleted the webview-flutter-latest-pigeon branch March 28, 2023 17:38
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
Update webview_flutter_wkwebview to newer pigeon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: webview_flutter platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants