Skip to content

Update file_selector_* to the latest pigeon #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 28, 2023
Merged

Update file_selector_* to the latest pigeon #3562

merged 12 commits into from
Mar 28, 2023

Conversation

natebosch
Copy link
Contributor

The current version is incompatible with the latest analyzer, which is a blocker for getting the latest mockito, which is a blocker for getting the latest test_api, which is pinned by flutter_test and will be breaking in the next package roll.

Also update to the latest build_runner and use a range constraint since the older build_runner is also incompatible with the latest analyzer.

@natebosch
Update file_selector_ios to the latest pigeon
6d74c8a 
The current version is incompatible with the latest analyzer, which is a
blocker for getting the latest mockito, which is a blocker for getting
the latest test_api, which is pinned by flutter_test and will be
breaking in the next package roll.

Also update to the latest `build_runner` and use a range constraint
since the older `build_runner` is also incompatible with the latest
`analyzer`.
@natebosch natebosch requested a review from jmagman as a code owner March 27, 2023 17:51
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@natebosch natebosch requested a review from cbracken as a code owner March 27, 2023 17:54
@natebosch natebosch changed the title Update file_selector_ios to the latest pigeon Update file_selector_* to the latest pigeon Mar 27, 2023
stuartmorgan-g
stuartmorgan-g requested changes Mar 27, 2023
View reviewed changes
@stuartmorgan-g
Copy link
Contributor

I pushed an update for the breaking changes affecting macOS.

@Hixie
Copy link
Contributor

Hixie commented Mar 27, 2023

test-exempt: dependency roll

@stuartmorgan-g
Copy link
Contributor

Oops, native tests. Fix incoming.

@natebosch natebosch added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 27, 2023

auto label is removed for flutter/packages, pr: 3562, due to This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan}, please make the needed changes and resubmit this PR.
You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 27, 2023

auto label is removed for flutter/packages, pr: 3562, due to - This pull request has changes requested by @stuartmorgan. Please resolve those before re-applying the label.

stuartmorgan-g
stuartmorgan-g approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit auto-submit bot merged commit 69110b0 into flutter:main Mar 28, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
69110b0 Update file_selector_* to the latest pigeon (flutter/packages…
0e0d5bd 
…#3562)
@natebosch natebosch deleted the file-selector-ios-latest-pigeon branch March 28, 2023 17:38
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@natebosch @nploi
Update file_selector_* to the latest pigeon (flutter#3562)
dbe7faa 
Update file_selector_* to the latest pigeon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@jmagman jmagman Awaiting requested review from jmagman

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: file_selector platform-ios platform-macos platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natebosch @stuartmorgan-g @Hixie