Skip to content

[image_picker] bump androidx.activity:activity to 1.7.0 #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tarrinneal
Copy link
Contributor

bumps androidx.activity:activity to 1.7.0

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal tarrinneal requested a review from gmackall as a code owner March 23, 2023 21:29
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tarrinneal
Copy link
Contributor Author

@gmackall any chance you can help me with the failing tests? I'm not entirely sure what the conflict is. I'm sure it's simple enough though.

@gmackall
Copy link
Member

Oh interesting, this seems to be the same failure as the one on this dependabot pr
#3381. I put an initial guess as to the cause in the comments, but I'm actually not sure yet.

@gmackall
Copy link
Member

I've made an issue to track this failure flutter/flutter#125062 and have a pr to fix it in one of the existing dependabot upgrades. I'm waiting for that to be approved/merged to confirm it works as expected, and then I will take over this one as well.

@reidbaker
Copy link
Contributor

Note from triage @gmackall is taking this over.

@gmackall
Copy link
Member

Closing this as its a version with a solution to the duplicate class failures is here: #3968

@gmackall gmackall closed this May 11, 2023
auto-submit bot pushed a commit that referenced this pull request May 17, 2023
…y on kotlin-bom to align kotlin transitive dependencies (#3968)

Taking over #3536
bumps androidx.activity:activity to 1.7.0
Adds a workaround to fix duplicate class failures described here flutter/flutter#125062.
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…y on kotlin-bom to align kotlin transitive dependencies (flutter#3968)

Taking over flutter#3536
bumps androidx.activity:activity to 1.7.0
Adds a workaround to fix duplicate class failures described here flutter/flutter#125062.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants