-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[image_picker] bump androidx.activity:activity to 1.7.0 #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@gmackall any chance you can help me with the failing tests? I'm not entirely sure what the conflict is. I'm sure it's simple enough though. |
Oh interesting, this seems to be the same failure as the one on this dependabot pr |
14785b2
to
52f0646
Compare
I've made an issue to track this failure flutter/flutter#125062 and have a pr to fix it in one of the existing dependabot upgrades. I'm waiting for that to be approved/merged to confirm it works as expected, and then I will take over this one as well. |
Note from triage @gmackall is taking this over. |
Closing this as its a version with a solution to the duplicate class failures is here: #3968 |
…y on kotlin-bom to align kotlin transitive dependencies (#3968) Taking over #3536 bumps androidx.activity:activity to 1.7.0 Adds a workaround to fix duplicate class failures described here flutter/flutter#125062.
…y on kotlin-bom to align kotlin transitive dependencies (flutter#3968) Taking over flutter#3536 bumps androidx.activity:activity to 1.7.0 Adds a workaround to fix duplicate class failures described here flutter/flutter#125062.
bumps androidx.activity:activity to 1.7.0
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.