-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[image_picker] Adopt readme excerpts #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image_picker] Adopt readme excerpts #3507
Conversation
Converts the README from manually-maintained code snippets to using excerpts from a code file. Includes sanity check tests of the snippet code to make sure it runs successfully. Part of flutter/flutter#102679
``` dart | ||
import 'package:image_picker/image_picker.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this from the excerpt since I don't think there's much value in showing the standard import for using a package; we are mostly only doing this for unusual cases (like including platform implementation packages).
// Capture a photo. | ||
final XFile? photo = await picker.pickImage(source: ImageSource.camera); | ||
// Pick a video. | ||
final XFile? galleryVideo = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable names changed because there were variable redeclarations that didn't compile.
for (final XFile file in response.files) { | ||
_handleFile(file); | ||
} | ||
final List<XFile>? files = response.files; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to avoid having to !
; the code as written wasn't null-safe since it was doing a property lookup (which can't infer safety from earlier null checks).
auto label is removed for flutter/packages, pr: 3507, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
[image_picker] Adopt readme excerpts
Converts the README from manually-maintained code snippets to using excerpts from a code file.
Includes sanity check tests of the snippet code to make sure it runs successfully.
Part of flutter/flutter#102679
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).