-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player] #60048 ios picture in picture #3500
Open
vanlooverenkoen
wants to merge
93
commits into
flutter:main
Choose a base branch
from
vanlooverenkoen:feature/#60048-ios-picture-in-picture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
595d3df
#60048: Migration from flutter-plugins to flutter-packages
vanlooverenkoen 4831f57
Updated doc
vanlooverenkoen 976b630
Merged current main into ios pip
vanlooverenkoen a7d5dd5
#60048: Formatting
vanlooverenkoen 876dfe8
Fixed formatting
vanlooverenkoen a4ca9e7
#60048: Updated the changelogs
vanlooverenkoen 49f769a
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 5477f0b
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 0764e27
#60048: Updated comments related to docs & typo's
vanlooverenkoen 65fdf65
Renamed setAutomaticallyStartPictureInPicture to setAutomaticallyStar…
vanlooverenkoen d4d9ff9
Updated starting to started to match stopped enum values
vanlooverenkoen ff6d02f
Removed some logic to pause
vanlooverenkoen ae7500a
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 4eeb6e1
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 9110d0f
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 211c6b3
Fixed the formatting & pigeon run
vanlooverenkoen 5a8735b
Fixed documentation
vanlooverenkoen 4583229
Updated the dto's to setup the picture in picture
vanlooverenkoen 70284aa
Fixed documentation
vanlooverenkoen 7289998
Fixed 2 bugs where the permissions were not correct and an issue with…
vanlooverenkoen ee96f77
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen da13c09
Fixed formatting & tests
vanlooverenkoen 4d83a52
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen ac920fe
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 8394840
Fixed the version bumper for the the video_player itself
vanlooverenkoen 19b1440
Fixed comments
vanlooverenkoen 1963d27
Fixed some comments
vanlooverenkoen f71a27a
Fixed formaating
vanlooverenkoen b3e05a0
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 1325254
Fixed documentation
vanlooverenkoen 72ba79a
Fixed comment on UIBackgroundModes
vanlooverenkoen 8c67ab8
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen f935a16
Fixed a bug where the top & left overlay settings were incorrect
vanlooverenkoen 42a7815
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen fa93319
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen b0103d0
updated documentation
vanlooverenkoen 236ab51
fix ios tests
vanlooverenkoen 1cf961d
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 5c18256
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen ddc7139
camera override video_player plugin
vanlooverenkoen 45494b9
fix camera dependency overrides
vanlooverenkoen 0597f32
fix macos implementation (only do validation on capabilities on iOS &…
vanlooverenkoen 5c1f759
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen e94ccaa
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 9dc85a0
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 2b72605
fix formatting
vanlooverenkoen 601c506
fix formatting & unwanted changes
vanlooverenkoen 4574fa9
fix: remove the video_player dependency overrides
vanlooverenkoen 1135695
fix: add the dependency override of video_player_avfoundation
vanlooverenkoen cd7fede
fix: add all the correct dependency overrides
vanlooverenkoen e9aba08
changelog version to specific version
vanlooverenkoen 30c0b7a
Update pubspec.yaml
vanlooverenkoen c0ccbfc
Update pubspec.yaml
vanlooverenkoen 8ee1dcb
fix: formatting of video_player
vanlooverenkoen 58db59a
fix: compatability
vanlooverenkoen 16ae8cb
fix: integervalue
vanlooverenkoen a15c3b7
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 87b92c2
fix: test on macOS
vanlooverenkoen 5183028
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 002faa0
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 148cd55
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen d88cf33
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 45f96f5
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen 9459bd5
Merge branch 'main' into feature/#60048-ios-picture-in-picture
vanlooverenkoen d9f883b
fix formatting
vanlooverenkoen c9993dc
fix: macos checks
vanlooverenkoen 3e401c1
fix: comment
vanlooverenkoen b250e9c
fix: check on macOS where there are no capabilities required to use p…
vanlooverenkoen 01aaf8d
Revert "fix: add all the correct dependency overrides"
Nols1000 ee6db47
Revert "camera override video_player plugin"
Nols1000 2e3196b
Update the documentation on configuring the required ios capabilities
Nols1000 29c1d3b
Merge remote-tracking branch 'origin/main' into feature/#60048-ios-pi…
Nols1000 6d8fb1e
[video_player_android] regenerate pigeons
Nols1000 114f5b8
[video_player_avfoundation] regenerate pigeons
Nols1000 5861e1d
Revert changes to the camera_android_camerax example
Nols1000 114f9ac
[video_player] fix todo making the picture-in-picture message const
Nols1000 3c1b4e6
[video_player] add tests to ensure equals implementation for isPictur…
Nols1000 3985a77
[video_player_avfoundation] refactor picture in picture extension
Nols1000 1649be4
[video_player_avfoundation] refactor code
Nols1000 bc56139
[video_player] format code
Nols1000 e1348c8
[video_player_avfoundation] reorder imports
Nols1000 7e70da0
[video_player] update version
Nols1000 4abe6f1
[video_player_android] Revert all changes made to this package
Nols1000 2006494
[video_player] upgrade dependencies
Nols1000 58dabf4
[video_player] fix dependencies for example
Nols1000 881e80e
[video_player_android] add overwrite to fix analysis error
Nols1000 917bdd4
[video_player_avfoundation] fix type issue with isPictureInPictureSup…
Nols1000 fba55da
[video_player_avfoundation] refactore naming and setting the start of…
Nols1000 b0f42d8
[video_player] Update dependencies
Nols1000 e0231d8
Merge remote-tracking branch 'origin/main' into feature/#60048-ios-pi…
Nols1000 c58b722
[video_player] Upgrade dart version
Nols1000 376bcf5
[video_player] Update dependencies
Nols1000 5dd6e13
[camera] Add video_player_platform_interface to overwrite
Nols1000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed formatting & tests
- Loading branch information
commit da13c09dd94e855d665996bfd9435a7b2c0dfcdc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 0.001? The comment says "because it is an overlay." But why is it this number in that situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutter/plugins#6284 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand, either from the code comment or the linked discussion, what exactly this is doing. Please add detail to the code comment clearly explaining what the issue being worked around here is. What would happen if we removed this line, or if we used 0 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is updated, can you check if this is better for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this overlay intercept taps and other gestures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it does not