[go_router] Fixes an issue where the params are removed after popping #3401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
force-pushed
the
go-router-state-params
branch
2 times, most recently
from
e5bd7f1 to
66fb445
Compare
hannah-hyj
reviewed
Mar 20, 2023
packages/go_router/CHANGELOG.md
Outdated
| - Aligns Dart and Flutter SDK constraints. | ||
| - Updates compileSdkVersion to 33. | ||
| - Updates example app to iOS 11. | ||
|
|
||
| ## 6.2.0 | ||
|
|
||
| - Export supertypes in route_data.dart library | ||
| - Export supertypes in route_data.dart library. |
| router.go('/123'); | ||
| await tester.pumpAndSettle(); | ||
| expect(find.text('2 123'), findsOneWidget); | ||
| // The query parameter is removed, so is the location in first page. |
There was a problem hiding this comment.
What does this comment mean here? which query parameter and location in first page is removed?
| // The query parameter is removed, so is the location in first page. | ||
| router.pop(); | ||
| await tester.pump(); | ||
| expect(find.text('2 123'), findsOneWidget); |
There was a problem hiding this comment.
I don't get why it's still at page 2 after poping.
There was a problem hiding this comment.
Added a comment to explain.
chunhtai
force-pushed
the
go-router-state-params
branch
from
66fb445 to
7313652
Compare
chunhtai
force-pushed
the
go-router-state-params
branch
from
7313652 to
aa4d6a6
Compare
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…flutter#3401) [go_router] Fixes an issue where the params are removed after popping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pop will remove pathparameter from routeMatchList, and the goRouterState also use the same reference to the pathparameter in the routeMatchList, thus parameters got removed as well
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.