Skip to content

[in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 25, 2023
Merged

[in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android #3381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7349e75
[in_app_pur]: Bump androidx.annotation:annotation
dependabot[bot] Mar 21, 2023
f7fab0f
Update CHANGELOG.md
gmackall Mar 21, 2023
ab05ac1
Update pubspec.yaml
gmackall Mar 21, 2023
0563853
testing line to fix build issues
gmackall Apr 10, 2023
714aba6
Merge branch 'main' into dependabot/gradle/packages/in_app_purchase/i…
gmackall Apr 10, 2023
7945a10
Update build.gradle to accept review comments
gmackall Apr 18, 2023
62829fc
Merge branch 'main' into dependabot/gradle/packages/in_app_purchase/i…
gmackall Apr 25, 2023
b999b5c
Update pubspec.yaml
gmackall Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.2.5+2

* Updates androidx.annotation:annotation from 1.5.0 to 1.6.0.

## 0.2.5+1

* Adds a namespace for compatibility with AGP 8.0.
Expand Down
5 changes: 4 additions & 1 deletion packages/in_app_purchase/in_app_purchase_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ android {
}

dependencies {
implementation 'androidx.annotation:annotation:1.5.0'
implementation 'androidx.annotation:annotation:1.6.0'
// org.jetbrains.kotlin:kotlin-bom artifact purpose is to align kotlin stdlib and related code versions.
// See: https://youtrack.jetbrains.com/issue/KT-55297/kotlin-stdlib-should-declare-constraints-on-kotlin-stdlib-jdk8-and-kotlin-stdlib-jdk7
implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.8.0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker this is the line I was wondering about.

This link is where I got the idea from.

Copy link
Contributor

@reidbaker reidbaker Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not opposed to this but I think you should add the following comment.

// org.jetbrains.kotlin:kotlin-bom artifact purpose is to align kotlin stdlib and related code versions. 
// See: https://youtrack.jetbrains.com/issue/KT-55297/kotlin-stdlib-should-declare-constraints-on-kotlin-stdlib-jdk8-and-kotlin-stdlib-jdk7
implementation(platform("org.jetbrains.kotlin:kotlin-bom:$kotlinVersion"))

implementation 'com.android.billingclient:billing:5.1.0'
testImplementation 'junit:junit:4.13.2'
testImplementation 'org.json:json:20230227'
Expand Down
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: in_app_purchase_android
description: An implementation for the Android platform of the Flutter `in_app_purchase` plugin. This uses the Android BillingClient APIs.
repository: https://github.com/flutter/packages/tree/main/packages/in_app_purchase/in_app_purchase_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
version: 0.2.5+1
version: 0.2.5+2

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down