Skip to content

[pigeon] Only check generated files on master #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[pigeon] Only check generated files on master #3357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c370f9
[pigeon] Only check generated files on master
stuartmorgan-g Mar 2, 2023
c37d506
Fix reversed check
stuartmorgan-g Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/pigeon/tool/run_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,14 @@ Future<void> main(List<String> args) async {
// configurations have different setups (e.g., different clang-format versions
// or no clang-format at all).
if (Platform.isLinux) {
await _validateGeneratedTestFiles();
// Only run on master, since Dart format can change between versions.
// TODO(stuartmorgan): Make a more generic way to run this check only on
// master; this currently won't work for anything but Cirrus.
if (Platform.environment['CHANNEL'] == 'stable') {
print('Skipping generated file validation on stable.');
} else {
await _validateGeneratedTestFiles();
}
}

final List<String> testsToRun;
Expand Down