Skip to content

[camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
May 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7e72f24
Recreating PR from flutter/plugins
acoutts Feb 23, 2023
e0b5716
Log cleanup
acoutts Mar 9, 2023
c170fe0
Add test parameters
acoutts Mar 9, 2023
cb8dc5e
Tests for new image group type
acoutts Mar 9, 2023
093d9e7
Changelog spacing
acoutts Mar 9, 2023
c8ed510
Changelog spacing
acoutts Mar 9, 2023
000e783
Changelog spacing
acoutts Mar 9, 2023
97787d5
Add test to camera for nv21 image format
acoutts Mar 10, 2023
e19bfec
Merge remote-tracking branch 'upstream/main' into fix-handle-padding
acoutts Mar 10, 2023
fb6ec84
Merge remote-tracking branch 'upstream/main' into fix-handle-padding
acoutts Mar 10, 2023
14f2986
Remove tracked gradle files
acoutts Mar 10, 2023
1c03352
Handle cases where imageStreamReader is null to be ultra safe
acoutts Mar 13, 2023
b051e70
Merge remote-tracking branch 'upstream/main' into fix-handle-padding
acoutts Mar 13, 2023
7ae6b93
Formatters
acoutts Mar 13, 2023
c651052
Fix out of memory error during tests because mock image was too big
acoutts Mar 13, 2023
541b658
Merge remote-tracking branch 'upstream/main' into fix-handle-padding
acoutts Mar 28, 2023
0a418d9
Remove dependency override for camera_platform_interface from camera_…
acoutts Mar 28, 2023
c415eb2
Merge remote-tracking branch 'upstream/main' into fix-handle-padding
acoutts Apr 4, 2023
15b33da
Merge remote-tracking branch 'upstream/main' into fix-handle-padding
acoutts May 2, 2023
834e85e
Update CHANGELOG.md
acoutts May 2, 2023
dc2f248
Update Camera.java
acoutts May 2, 2023
5d866f4
Bump dep versions
acoutts May 2, 2023
6a17bc7
Update pubspec.yaml
acoutts May 2, 2023
467938b
Update pubspec.yaml
acoutts May 2, 2023
0c35521
Update pubspec.yaml
acoutts May 2, 2023
cfabbad
Changelog spacing and version
acoutts May 2, 2023
96fe939
Update pubspec.yaml
acoutts May 2, 2023
0e73f9a
Update pubspec.yaml
acoutts May 2, 2023
8ff5d68
Add back missing camera image test for bgra8888
acoutts May 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.5

* Adds NV21 as an image streaming option for Android.

## 0.10.4

* Allows camera to be switched while video recording.
Expand Down
3 changes: 3 additions & 0 deletions packages/camera/camera/lib/src/camera_image.dart
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ ImageFormatGroup _asImageFormatGroup(dynamic rawFormat) {
// android.graphics.ImageFormat.JPEG
case 256:
return ImageFormatGroup.jpeg;
// android.graphics.ImageFormat.NV21
case 17:
return ImageFormatGroup.nv21;
}
}

Expand Down
6 changes: 3 additions & 3 deletions packages/camera/camera/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
Dart.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.10.4
version: 0.10.5

environment:
sdk: ">=2.18.0 <4.0.0"
Expand All @@ -21,9 +21,9 @@ flutter:
default_package: camera_web

dependencies:
camera_android: ^0.10.5
camera_android: ^0.10.7
camera_avfoundation: ^0.9.13
camera_platform_interface: ^2.4.0
camera_platform_interface: ^2.5.0
camera_web: ^0.3.1
flutter:
sdk: flutter
Expand Down
25 changes: 25 additions & 0 deletions packages/camera/camera/test/camera_image_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,30 @@ void main() {
expect(cameraImage.format.group, ImageFormatGroup.yuv420);
});

test('$CameraImage has ImageFormatGroup.nv21 for android', () {
debugDefaultTargetPlatformOverride = TargetPlatform.android;

final CameraImage cameraImage =
CameraImage.fromPlatformData(<dynamic, dynamic>{
'format': 17,
'height': 1,
'width': 4,
'lensAperture': 1.8,
'sensorExposureTime': 9991324,
'sensorSensitivity': 92.0,
'planes': <dynamic>[
<dynamic, dynamic>{
'bytes': Uint8List.fromList(<int>[1, 2, 3, 4]),
'bytesPerPixel': 1,
'bytesPerRow': 4,
'height': 1,
'width': 4
}
]
});
expect(cameraImage.format.group, ImageFormatGroup.nv21);
});

test('$CameraImage has ImageFormatGroup.bgra8888 for iOS', () {
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;

Expand All @@ -162,6 +186,7 @@ void main() {
});
expect(cameraImage.format.group, ImageFormatGroup.bgra8888);
});

test('$CameraImage has ImageFormatGroup.unknown', () {
final CameraImage cameraImage =
CameraImage.fromPlatformData(<dynamic, dynamic>{
Expand Down