[pigeon] Add Kotlin parameters to run pigeon command #3260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
approved these changes
Feb 22, 2023
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Good catch, looks like we still need the c++ flags as well.
tarrinneal
added
the
override: no changelog needed
tarrinneal
removed
the
override: no changelog needed
stuartmorgan-g
requested changes
Feb 23, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
- I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.- I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.
You checked the boxes for these steps, but didn't do them. This README is published on pub.dev.
Contributor
Author
|
Sorry about that, I thought that just the main README.md was published on pub.dev. I'm seeing now that the example/README is there too. I'll update the pr ASAP. |
Contributor
Author
|
I've updated CHANGELOG and pubspec and rebased with upstream. |
github-actions
bot
added
platform-android
platform-ios
platform-macos
platform-windows
labels
Contributor
Author
|
Not sure why tests are still failing |
Contributor
Author
|
Got it, |
Contributor
|
@stuartmorgan I believe this is ready for a second review now. |
stuartmorgan-g
added
the
autosubmit
Collaborator
|
Some other Pigeon PRs landed; could you re-rev the version here? |
stuartmorgan-g
removed
the
autosubmit
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[pigeon] Add Kotlin parameters to run pigeon command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example parameters to generate Kotlin code in pigeon's example as described in the attached issue.
I didn't update pigeon changelog since pigeon/example/README.md isn't published on pub.dev.
Thanks!
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#121238
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
N/A
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.