Skip to content

Move iOS Swift unit tests back to Cirrus #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified .ci/scripts/build_all_packages_app.sh
100644 → 100755
Empty file.
Empty file modified .ci/scripts/create_all_packages_app.sh
100644 → 100755
Empty file.
Empty file modified .ci/scripts/create_simulator.sh
100644 → 100755
Empty file.
Empty file modified .ci/scripts/dart_unit_tests_win32.sh
100644 → 100755
Empty file.
Empty file modified .ci/scripts/drive_examples_win32.sh
100644 → 100755
Empty file.
Empty file modified .ci/scripts/plugin_tools_tests.sh
100644 → 100755
Empty file.
5 changes: 5 additions & 0 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,11 @@ task:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
# Create an iPhone 13, to match what is available on LUCI, since Pigeon tests
# currently have a hard-coded device.
create_simulator_script:
- xcrun simctl list
- xcrun simctl create "iPhone 13" com.apple.CoreSimulator.SimDeviceType.iPhone-13 com.apple.CoreSimulator.SimRuntime.iOS-16-0
local_tests_script:
# script/configs/linux_only_custom_test.yaml
# Custom tests need Chrome for these packages. (They run in linux-custom_package_tests)
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/tool/run_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ Future<void> main(List<String> args) async {
// separation. See https://github.com/flutter/flutter/issues/120231.
const List<String> macOSHostLuciTests = <String>[
iOSObjCUnitTests,
iOSSwiftUnitTests,
// TODO(stuartmorgan): Enable by default once CI issues are solved; see
// https://github.com/flutter/packages/pull/2816.
//iOSObjCIntegrationTests,
Expand All @@ -60,6 +59,7 @@ Future<void> main(List<String> args) async {
// iOSSwiftIntegrationTests,
];
const List<String> macOSHostCirrusTests = <String>[
iOSSwiftUnitTests,
macOSSwiftUnitTests,
macOSSwiftIntegrationTests,
];
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/tool/shared/test_suites.dart
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ Future<int> _runIOSPluginUnitTests(String testPluginPath) async {
return runXcodeBuild(
'$examplePath/ios',
sdk: 'iphonesimulator',
destination: 'platform=iOS Simulator,name=iPhone 8',
destination: 'platform=iOS Simulator,name=iPhone 13',
extraArguments: <String>['test'],
);
}
Expand Down