Skip to content

[ci] Increase iOS sharding #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 41 additions & 19 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,51 +66,70 @@ targets:
target_file: ios_build_all_packages.yaml
channel: stable

# TODO(stuartmorgan): Remove "- packages" from all task names once
# flutter/plugins is merged into this repo and turned down; it's here only
# because names must be unique across all flutter repositories.
- name: Mac_arm64 ios_platform_tests_1_of_4 master - packages
- name: Mac_arm64 ios_platform_tests_shard_1 master
bringup: true # New task
recipe: packages/packages
timeout: 60
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 0 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_shard_2 master
bringup: true # New task
recipe: packages/packages
timeout: 60
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 0 --shardCount 4"
package_sharding: "--shardIndex 1 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_2_of_4 master - packages
- name: Mac_arm64 ios_platform_tests_shard_3 master
Copy link
Contributor Author

@stuartmorgan-g stuartmorgan-g Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding - plugins to the new name in flutter/plugins so the collision will be in the repo that will go away rather than this repo, avoiding the need to rename all of these later.

bringup: true # New task
recipe: packages/packages
timeout: 60
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 1 --shardCount 4"
package_sharding: "--shardIndex 2 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_3_of_4 master - packages
- name: Mac_arm64 ios_platform_tests_shard_4 master
bringup: true # New task
recipe: packages/packages
timeout: 60
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 2 --shardCount 4"
package_sharding: "--shardIndex 3 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_4_of_4 master - packages
- name: Mac_arm64 ios_platform_tests_shard_5 master
bringup: true # New task
recipe: packages/packages
timeout: 60
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 3 --shardCount 4"
package_sharding: "--shardIndex 4 --shardCount 5"

# Don't run full platform tests on both channels in pre-submit.
- name: Mac_arm64 ios_platform_tests_1_of_4 stable - packages
- name: Mac_arm64 ios_platform_tests_shard_1 stable
bringup: true # New task
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 0 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_shard_2 stable
bringup: true # New task
recipe: packages/packages
presubmit: false
Expand All @@ -120,9 +139,9 @@ targets:
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 0 --shardCount 4"
package_sharding: "--shardIndex 1 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_2_of_4 stable - packages
- name: Mac_arm64 ios_platform_tests_shard_3 stable
bringup: true # New task
recipe: packages/packages
presubmit: false
Expand All @@ -132,9 +151,9 @@ targets:
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 1 --shardCount 4"
package_sharding: "--shardIndex 2 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_3_of_4 stable - packages
- name: Mac_arm64 ios_platform_tests_shard_4 stable
bringup: true # New task
recipe: packages/packages
presubmit: false
Expand All @@ -144,9 +163,9 @@ targets:
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 2 --shardCount 4"
package_sharding: "--shardIndex 3 --shardCount 5"

- name: Mac_arm64 ios_platform_tests_4_of_4 stable - packages
- name: Mac_arm64 ios_platform_tests_shard_5 stable
bringup: true # New task
recipe: packages/packages
presubmit: false
Expand All @@ -156,7 +175,7 @@ targets:
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 3 --shardCount 4"
package_sharding: "--shardIndex 4 --shardCount 5"

### macOS desktop tasks ###
# macos-platform_tests builds all the packages on ARM, so this build is run
Expand All @@ -179,6 +198,9 @@ targets:
target_file: mac_build_all_packages.yaml
channel: stable

# TODO(stuartmorgan): Remove "- packages" from all task names once
# flutter/plugins is merged into this repo and turned down; it's here only
# because names must be unique across all flutter repositories.
- name: Mac_arm64 macos_platform_tests master - packages
bringup: true # New task
recipe: packages/packages
Expand Down