Use Cirrus compute credits in PRs for collaborators #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
LGTM. I was going too ask whether we're sure this works as a top-level key since the docs don't say, but I see from the rest runs that it did (which raises serious questions about the utility of the collaborator restriction against malicious PRs...)
We should probably make the lightweight tasks use lighter VMs like I did for plugins, but that can be a follow-up later; over time I would like to align the two repos more so will be iterating more.
stuartmorgan
pushed a commit
to stuartmorgan/packages
that referenced
this pull request
Apr 30, 2021
austinstoker
pushed a commit
to austinstoker/packages
that referenced
this pull request
Apr 29, 2022
Support for any type of custom route builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use Cirrus compute credits for flutter-hackers in PRs. The macOS tests were already doing this, change the Linux task to match.
@kf6gpe agreed this is fine for this particular low-traffic (~5 commits per month) repo.