Skip to content

[pigeon] revert 3b5ae0070738103a80bb9ac12440dd69d598ad2c #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 21, 2022

Conversation

tarrinneal
Copy link
Contributor

reverts 3b5ae00

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine keeping this in if you want, we can just land another PR that does the refactor I mentioned in another PR. I can do that possibly tomorrow if you want. Or if you are interested, just let me know. In reality probably no one will add another language anytime soon or fiddle with the code that sets up the generators.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@auto-submit auto-submit bot merged commit 90c46d2 into flutter:main Dec 21, 2022
@tarrinneal tarrinneal removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@tarrinneal
Copy link
Contributor Author

I'm fine keeping this in if you want, we can just land another PR that does the refactor I mentioned in another PR. I can do that possibly tomorrow if you want. Or if you are interested, just let me know. In reality probably no one will add another language anytime soon or fiddle with the code that sets up the generators.

@gaaclarke I'm going to restructure things and send up a new pr tomorrow that isn't as reorganizational

@@ -1,7 +1,3 @@
## 4.2.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future please don't land straight reverts of package updates that have been published, as it creates issues for the next version bump. This should have been 4.2.16 instead.

I've retracted 4.2.15 so we don't have a version in the wild that we no longer have source for, but please do a new PR that restores this changelog entry, with a note saying it was retracted, and restores 4.2.15 as the version, so that the next PR will, correctly, change it to 4.2.16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed flutter/flutter#117458 because this should be enforced by CI, rather than relying on everyone contributing to flutter/packages and flutter/plugins somehow knowing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants