[go_router] Fixes crashes when popping navigators manually #2952
Conversation
| @@ -16,7 +16,7 @@ import 'typedefs.dart'; | |||
|
|
|||
| /// GoRouter implementation of [RouterDelegate]. | |||
| class GoRouterDelegate extends RouterDelegate<RouteMatchList> | |||
| with PopNavigatorRouterDelegateMixin<RouteMatchList>, ChangeNotifier { | |||
There was a problem hiding this comment.
We missed this when we refactor the pop. PopNavigatorRouterDelegateMixin is no longer needed since we override poproute directly
| @@ -1012,6 +1012,80 @@ void main() { | |||
| ]); | |||
| }); | |||
|
|
|||
| testWidgets('Can manually pop root navigator and display correct url', | |||
There was a problem hiding this comment.
Can we also add a test case that pop multiple times?
I think this PR would fix flutter/flutter#117431 but just want to make sure of it.
I added a test case for it in this PR: #2989 but since it's close, I'd like to add it in this PR at least.
There was a problem hiding this comment.
added on pop twice
There was a problem hiding this comment.
Thanks ;)
I have no right to approve the PR but everything looks good to me.
|
#2989 could be added to the issue list since it's a potential fix for it as well. |
chunhtai
force-pushed
the
issues/116784
branch
from
d3a7a4d to
9b2225b
Compare
|
looks like this is blocked on #2977 |
|
This issue is also fixed with this pr. |
chunhtai
force-pushed
the
issues/116784
branch
from
9b2225b to
2dec4a9
Compare
fixes flutter/flutter#116784
fixes flutter/flutter#116769
fixes flutter/flutter#117431
The issue is that the app bar will pop the root navigator and skipping the navigator in the shellroute, and the goRouter only expect the RouteMatchList to be popped start from the last RouteMatch. This pr fixes it so that it can handle the case where developer may manually pop any navigator.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.