[go_router] When `replace` is called, reuse the same key when possible #2846

ValentinVignal · 2022-11-24T09:31:45Z

I've introduced PageKey to be used as a key for the pages instead of ValueKey<String>. In that way, it is easy to know if 2 keys are from the same path or not.

I'm not too confident about my changes in

packages/go_router/lib/src/match.dart: It uses the hashCode
packages/go_router/lib/src/builder.dart: This is the only place I had to use fullPath. So maybe we could use path directly?

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai

I think the push and replace is different enough that we should probably not reuse push in replace method, or have a common private method that just take a non-null page key.

chunhtai · 2022-11-28T21:11:20Z

packages/go_router/lib/src/delegate.dart

-    final ValueKey<String> pageKey =
-        ValueKey<String>('${matches.fullpath}-p$count');
+    final PageKey pageKey;
+    if (keyToUse?.path == matches.fullpath) {


why do we need this check? why not just use keyToUse if it is not null?

Because if the page is different and the key doesn't match, ex: /family/:fid and /family, it shouldn't reuse it, right?

I could have named keyToUse keyToReuseIfPossible to be more explicit but it was a bit long

ValentinVignal · 2022-11-29T03:42:17Z

@chunhtai I refactored push and replace to use 2 common private methods in ♻️ Make replace and push use common methods

chunhtai · 2022-11-29T16:55:57Z

packages/go_router/lib/src/delegate.dart

-    push(matches); // [push] will notify the listeners.
+    assert(matches.last.route is! ShellRoute);
+    PageKey pageKey = _matchList.pop().pageKey;
+    if (pageKey.path != matches.fullpath) {


Seems weird to sometimes reuse and sometimes push. I am not 100% sure this is the route we should go. I was looking at the navigator API, it looks like this mixes both Navigator.replace and Navigator.pushReplacement. Based on the implemented API, this is more close to pushReplacement. In that case we should probably always trigger a push, and create another API to do the replace

Are you suggesting that we implement a

pushReplacement that always uses a new key

replace that always reuses the key of the replaced page

?

If yes, how would you want me to name those methods? pushReplacement and replace too? I don't know whether it will be considered as a breaking change or not

And in the case of /a being replaced by /b with replace, would it make sense to reuse /as key and see /b's screen while using /a as a key?

I think we should probably rename this to pushReplacement and always does a push. I think implementing replace is a bit risky because we need to worry about people replacing shellRoute. I would probably leave it out for now until we figure out these corner cases

I'm okay to rename the current replace into pushReplacement.
But how do I handle that? Do I make it a breaking change? Or do I deprecate replace and make it return pushReplacement ?

Also, I guess you want this pushReplacement to already generate and use a brand new key, right?
The fix needed to fix flutter/flutter#115902 is to reuse the key when possible

I will leave the original issue as a feature request, but I don't think that is something we should do.

Do you mean you want to leave replace (and reuse the same key) as a feature request but it would not be implemented?

How would suggest I can fix the bug mentioned in flutter/flutter#115902?

I can see a lot of corner cases if we implement this API, if you have an idea on how to implement it, feel free to send a pr

What about something similar to what I implemented in this PR?
It would reuse the same key if the path (ex: /families/:fid) is the same. Otherwise, it creates a new key?

I can modify this PR once #2848 is merged

MarufHassan17 · 2022-12-23T09:50:29Z

Please add the option which displays depreciated with the new term in VSCode and Android Studio when hovering over replaceNamed

ValentinVignal · 2022-12-23T21:01:34Z

@chunhtai What do you think about this implementation?
I didn't implement replaceNamed because I read you wanted to remove the named route API at some point (flutter/flutter#107729)

ValentinVignal · 2022-12-23T21:13:00Z

It looks like the checks are failing because of go_router_builder
I believe #2977 should fix it

chunhtai · 2023-01-04T17:40:00Z

@chunhtai What do you think about this implementation? I didn't implement replaceNamed because I read you wanted to remove the named route API at some point (flutter/flutter#107729)

We decide to keep named location since we couldn't come up with a better alternative, and functionality wise it works fine.

ValentinVignal · 2023-01-09T08:06:58Z

@chunhtai What do you think about this implementation? I didn't implement replaceNamed because I read you wanted to remove the named route API at some point (flutter/flutter#107729)

We decide to keep named location since we couldn't come up with a better alternative, and functionality wise it works fine.

Ok I can add replaceNamed, but before I do that. Is the implementation fine with you?

# Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/lib/src/delegate.dart # packages/go_router/lib/src/match.dart # packages/go_router/lib/src/matching.dart # packages/go_router/pubspec.yaml

ValentinVignal · 2023-01-09T15:01:15Z

I implemented replaceNamed in ✨ Add replaceNamed

ValentinVignal · 2023-01-09T15:03:16Z

Please add the option which displays depreciated with the new term in VSCode and Android Studio when hovering over replaceNamed

@MarufHassan17, I'm not sure I understand what you mean? Did you mean I should add the @Deprecated decorator to replaceNamed? If yes, replaceNamed has already been deleted in #2848 and got renamed into pushReplacementNamed (it is a breaking change)

ValentinVignal · 2023-01-17T03:09:11Z

@chunhtai What do you think of this implementation?

Or do you think the key should always be reused when the user calls replace ?
It's either we

Only reuse the same key when the location is the same. But this prevents the user to be able from reusing/preserving any state between 2 similar routes (ex : /my-form/:form-id and /my-form/:form-id/edit) with 2 different locations. And it will force the user to reuse the same route (ex: /my-form/:form-id and /my-form/:form-id?edit=true). I don't know whether it is good or bad.
Always reuse the same key. We let the user decide whether or not he wants to keep the state of its widget tree by using replace or lose it by using pushReplacement. This will allow to have animations/reuse the state between 2 similar routes with a different location (ex : /my-form/:form-id and /my-form/:form-id/edit) (and I don't know whether it is good or bad either). However, using the location of the routes for the keys wouldn't make so much sense anymore as the new route could have nothing related to the location of the reused key. And it will need to be changed.

What do you think?

chunhtai

sorry for the late reply, I just come back from vacation.

chunhtai · 2023-01-31T19:34:20Z

packages/go_router/lib/src/delegate.dart

    _matchList.remove(_matchList.last);
    push(matches); // [push] will notify the listeners.
  }

+  /// Replaces the top-most page of the page stack with the given one and reuse


This doc should not talk about page key since that is implementation detail. Instead it should talk about the visual effect of calling this method. Same thing for pushReplacement

This seems not addressed yet?

@chunhtai I could write in the doc that pushReplacement animates to the new page while replace does not.
But it is not only that, pushReplacement doesn't preserve the state of the widget tree while replace does. I think this is an important aspect that needs to be said and that's why I'm mentioning the page key.

Having said this, what do you think I should write?

You should definitely mention animation/page transition and that the it will be treated as same page and state will be preserved. I am ok if either you keep the page key info here or not.

This doesn't seem to be addressed yet

chunhtai · 2023-01-31T19:34:35Z

packages/go_router/lib/src/delegate.dart

+  /// See also:
+  /// * [push] which pushes the given location onto the page stack.
+  /// * [pushReplacement] which replaces the top-most page of the page stack but
+  ///   always use a new page key.


chunhtai · 2023-01-31T19:37:14Z

packages/go_router/lib/src/delegate.dart

+  /// * [push] which pushes the given location onto the page stack.
+  /// * [pushReplacement] which replaces the top-most page of the page stack but
+  ///   always use a new page key.
+  void replace(RouteMatchList matches) {


This method starts to deviate from Navigator.replace, which can replace any route instead of just the top one. One thing I think that may be useful would be replace GoRoute with an other GoRoute. maybe we can use GoRoute.name as here? WDYT?

also cc @johnpryan for API feedback

I'm not trying to re-implement Navigator.replace API here. The main goal of this PR is to fix flutter/flutter#115902. The solution I came up with was this replace method (which we could name differently, ex: replaceLast). I don't know whether re-implementing Navigator.replace would fix the issue (maybe it will not re-use the same key, like pushReplacement) or not.

Having this in mind, what do you think we should do in this PR?

I think the key only matter when replacing the top-most page?

My worry is that someone later on may file another feature request to replace the middle of match list, and then we would need to come up with a new api since the function signature here cannot be reused.

I also been thinking about opening up the RouteMatchList and all the package level private class. That may open a better way to manage the RouteMatchList.

So I think there are two ways to go from here. Either we expand this to be able to replace any GoRoute(or a sub list of RouteBases) with one or more RouteBases. Or we open up the API now and let customers to do their things.

So I think there are two ways to go from here. Either we expand this to be able to replace any GoRoute(or a sub list of RouteBases) with one or more RouteBases. Or we open up the API now and let customers to do their things.

Is there a way you prefer over the other? I guess I can try to implement the replace method here

Hello @chunhtai I tried to look a bit at how it could be possible to make replace a bit like

void Navigator.replace({ required Route<dynamic> oldRoute, required Route<T> newRoute})

So I guess, from what you said:

One thing I think that may be useful would be replace GoRoute with an other GoRoute. maybe we can use GoRoute.name as here

replace could have one of the signatures (if routeNameToReplace is null, it would replace the top most route).

void replace(RouteMatchList matchese, {String? routeNameToReplace}); void replace(RouteBase newRoute, {String? routeNameToReplace});

There are several issues with this:

If a route is present multiple times in the history, which one is supposed to be replaced?

This solution doesn't work with go_router_builder as all the generated routes are nameless.

About your concerns

My worry is that someone later on may file another feature request to replace the middle of match list, and then we would need to come up with a new api since the function signature here cannot be reused.

The signature of the method replace of the delegate could be changed easily as it is not opened yet, so there should not be any issues there.

The signature of the method replace of the router should not be breaking. It could change from

void replace(String location, {Object? extra});

to

void replace(String location, {WhateverType? whateverParameter, Object? extra});

What do you think?

I am still slightly concern about using a string location to do the replace, but i can't find a better alternative. yeah, I am ok with this approach

please re-request me for review when this pr is ready.

yeah, I am ok with this approach

What approach are you okay with? The one currently implemented in this PR ? (If yes, it would be ready to review)

If you are talking about

void replace(RouteMatchList matchese, {String? routeNameToReplace}); void replace(RouteBase newRoute, {String? routeNameToReplace});

What about

There are several issues with this:

If a route is present multiple times in the history, which one is supposed to be replaced?

This solution doesn't work with go_router_builder as all the generated routes are nameless.

?

the current implementation

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml

ValentinVignal · 2023-02-09T04:02:30Z

@chunhtai When you review, could you take a look at #2846 (comment)

Or do you think the key should always be reused when the user calls replace ? It's either we

Only reuse the same key when the location is the same. But this prevents the user to be able from reusing/preserving any state between 2 similar routes (ex : /my-form/:form-id and /my-form/:form-id/edit) with 2 different locations. And it will force the user to reuse the same route (ex: /my-form/:form-id and /my-form/:form-id?edit=true). I don't know whether it is good or bad.

Always reuse the same key. We let the user decide whether or not he wants to keep the state of its widget tree by using replace or lose it by using pushReplacement. This will allow to have animations/reuse the state between 2 similar routes with a different location (ex : /my-form/:form-id and /my-form/:form-id/edit) (and I don't know whether it is good or bad either). However, using the location of the routes for the keys wouldn't make so much sense anymore as the new route could have nothing related to the location of the reused key. And it will need to be changed.

What do you think?

I'm not sure which implementation would be best

ValentinVignal · 2023-02-19T11:22:02Z

@chunhtai I updated the doc in docs: Update the doc of replace to mention animation and state

Tell me if it is good enough for you

chunhtai · 2023-02-21T18:12:53Z

packages/go_router/lib/src/misc/extensions.dart

@@ -89,4 +99,29 @@ extension GoRouterHelper on BuildContext {
        queryParams: queryParams,
        extra: extra,
      );
+
+  /// Replaces the top-most page of the page stack with the given one.


Can you also mention the transition and preserve state behavior somewhere in here as well?

packages/go_router/lib/src/misc/extensions.dart

chunhtai · 2023-02-21T18:13:27Z

packages/go_router/lib/src/router.dart

@@ -272,6 +282,45 @@ class GoRouter extends ChangeNotifier implements RouterConfig<RouteMatchList> {
    );
  }

+  /// Replaces the top-most page of the page stack with the given one.
+  ///


here as well

chunhtai · 2023-02-21T18:13:34Z

packages/go_router/lib/src/router.dart

+
+  /// Replaces the top-most page of the page stack with the named route w/
+  /// optional parameters, e.g. `name='person', params={'fid': 'f2', 'pid':
+  /// 'p1'}`.


here as well

ValentinVignal · 2023-02-22T01:20:34Z

@chunhtai Sorry for the misses, I added the doc in docs: Add more doc to replace and replaceNamed

johnpryan · 2023-02-22T20:49:11Z

@stuartmorgan @ditman can you help us figure out why CI is failing?

ditman · 2023-02-22T21:17:44Z

@stuartmorgan @ditman can you help us figure out why CI is failing?

@johnpryan "submit-queue" is the check that asserts that whatever is at the tip of flutter/packages main branch is passing all post-submit tests.

It looks red now, because flutter/packages main is undergoing testing (here), but once that finishes correctly, it'll turn green in this PR as well.

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml

ditman · 2023-03-01T02:24:40Z

Updated branch to fix merge conflicts.

@chunhtai I've seen you've made some comments after LGTMing. Please, take another look, and if you're still good with this landing, set the autosubmit label (else withdraw your approval, please!) :P

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md

chunhtai

some of the doc is still missing

chunhtai · 2023-03-03T16:24:29Z

packages/go_router/lib/src/delegate.dart

+  /// Replaces the top-most page of the page stack with the given one. The page
+  /// key of the new page will always be different from the old one.


Suggested change

/// Replaces the top-most page of the page stack with the given one. The page

/// key of the new page will always be different from the old one.

/// Replaces the top-most page of the page stack with the given one.

///

/// The page key of the new page will always be different from the old one.

Sorry for that. Hopefully docs: Improve the documentation addressed all your comments

chunhtai · 2023-03-03T16:25:28Z

packages/go_router/lib/src/delegate.dart

    _matchList.remove(_matchList.last);
    push(matches); // [push] will notify the listeners.
  }

+  /// Replaces the top-most page of the page stack with the given one and reuse


This doesn't seem to be addressed yet

chunhtai · 2023-03-03T16:26:32Z

packages/go_router/lib/src/router.dart

@@ -272,6 +282,48 @@ class GoRouter extends ChangeNotifier implements RouterConfig<RouteMatchList> {
    );
  }

+  /// Replaces the top-most page of the page stack with the given one but treats
+  /// it as the same page. The page key will be reused. This will preserve the


The first paragraph should always be one brief sentence

chunhtai · 2023-03-03T16:26:54Z

packages/go_router/lib/src/router.dart

+    });
+  }
+
+  /// Replaces the top-most page of the page stack with the named route w/


Suggested change

/// Replaces the top-most page of the page stack with the named route w/

/// Replaces the top-most page of the page stack with the named route with

chunhtai · 2023-03-03T16:27:29Z

packages/go_router/lib/src/router.dart

+
+  /// Replaces the top-most page of the page stack with the named route w/
+  /// optional parameters, e.g. `name='person', params={'fid': 'f2', 'pid':
+  /// 'p1'}`. But it treats it as the same page. The page key will be reused.


The first paragraph should be one sentence

chunhtai · 2023-03-03T16:28:23Z

packages/go_router/lib/src/misc/extensions.dart

@@ -89,4 +99,32 @@ extension GoRouterHelper on BuildContext {
        queryParams: queryParams,
        extra: extra,
      );
+
+  /// Replaces the top-most page of the page stack with the given one but treats
+  /// it as the same page. The page key will be reused. This will preserve the


chunhtai · 2023-03-03T16:28:36Z

packages/go_router/lib/src/misc/extensions.dart

+
+  /// Replaces the top-most page of the page stack with the named route w/
+  /// optional parameters, e.g. `name='person', params={'fid': 'f2', 'pid':
+  /// 'p1'}`. But it treats it as the same page. The page key will be reused.


…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md

ValentinVignal · 2023-03-10T01:37:10Z

@chunhtai @Hangyujin is there anything else I need to do ?

ValentinVignal · 2023-03-16T01:28:16Z

@chunhtai @Hangyujin If the code looks good to you, do you think we can go through with this PR?

hannah-hyj

LGTM

ValentinVignal · 2023-03-20T08:51:26Z

@chunhtai @Hangyujin , the check submit-queue keeps failing on this PR (and not on #3462 for example), am I supposed to do something about it?

chunhtai · 2023-03-20T16:45:23Z

@ValentinVignal no that means the current tip of tree is broken, it would be us to fix it. No action item on your side.

…e-key-when-replace

auto-submit · 2023-03-21T01:13:18Z

auto label is removed for flutter/packages, pr: 2846, due to - The status or check suite Windows win32-platform_tests stable - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

… possible (flutter/packages#2846)

flutter#2846) [go_router] When `replace` is called, reuse the same key when possible

ValentinVignal requested a review from chunhtai as a code owner November 24, 2022 09:31

github-actions bot added the p: go_router label Nov 24, 2022

chunhtai reviewed Nov 28, 2022

View reviewed changes

ValentinVignal requested a review from chunhtai November 29, 2022 03:42

chunhtai reviewed Nov 29, 2022

View reviewed changes

chunhtai mentioned this pull request Dec 1, 2022

[go_router] Add GoRouterState parameters to GoRouterData and rename replace methods #2848

Merged

11 tasks

chunhtai mentioned this pull request Dec 15, 2022

[go_router_builder] Generate replace method in RouteExtension #2838

Merged

11 tasks

ValentinVignal added 4 commits December 24, 2022 04:57

♻️ Use PageKey

9098a28

✨ Add replace method

b9f2edc

:whie_check_mark: Update the tests

2b5bcba

⬆️ Update the version number

f85f785

ValentinVignal force-pushed the go-router/reuse-same-key-when-replace branch from 9b5769c to f85f785 Compare December 23, 2022 20:58

ValentinVignal requested a review from chunhtai December 23, 2022 21:01

ValentinVignal added 2 commits January 9, 2023 22:41

Merge branch 'main' into go-router/reuse-same-key-when-replace

91e5179

# Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/lib/src/delegate.dart # packages/go_router/lib/src/match.dart # packages/go_router/lib/src/matching.dart # packages/go_router/pubspec.yaml

✨ Add replaceNamed

7bff073

ValentinVignal mentioned this pull request Jan 18, 2023

[go_router] Implement popUntil #2728

Closed

11 tasks

chunhtai reviewed Jan 31, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into go-router/reuse-sam…

be76f27

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml

chunhtai self-requested a review February 8, 2023 18:01

Merge remote-tracking branch 'upstream/main' into go-router/reuse-sam…

0ea396a

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml

chunhtai reviewed Feb 21, 2023

View reviewed changes

ValentinVignal added 2 commits February 22, 2023 09:10

Merge branch 'main' into go-router/reuse-same-key-when-replace

b0a30ef

docs: Add more doc to replace and replaceNamed

7be1963

ValentinVignal and others added 2 commits February 23, 2023 09:21

Merge remote-tracking branch 'upstream/main' into go-router/reuse-sam…

1fd6b27

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml

Merge branch 'main' into go-router/reuse-same-key-when-replace

f78050b

chunhtai self-requested a review March 2, 2023 22:42

Merge remote-tracking branch 'upstream/main' into go-router/reuse-sam…

e84f996

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md

chunhtai reviewed Mar 3, 2023

View reviewed changes

ValentinVignal added 2 commits March 5, 2023 12:21

Merge remote-tracking branch 'upstream/main' into go-router/reuse-sam…

d6be74d

…e-key-when-replace # Conflicts: # packages/go_router/CHANGELOG.md

docs: Improve the documentation

58853df

hannah-hyj approved these changes Mar 16, 2023

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023

Merge remote-tracking branch 'upstream/main' into go-router/reuse-sam…

799a6c0

…e-key-when-replace

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023

auto-submit bot merged commit bb3bfd6 into flutter:main Mar 21, 2023

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Roll Packages from 694f82b34316 to 75491e98c0d1 (15 revisions) flutter/flutter#123215

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023

bb3bfd6 [go_router] When replace is called, reuse the same key when…

01c6872

… possible (flutter/packages#2846)

HansMuller mentioned this pull request Mar 24, 2023

Flutter Framework Team: Notable Commits flutter/flutter#121415

Closed

nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023

[go_router] When replace is called, reuse the same key when possible (

f3eac67

flutter#2846) [go_router] When `replace` is called, reuse the same key when possible

		/// Replaces the top-most page of the page stack with the given one. The page
		/// key of the new page will always be different from the old one.

[go_router] When replace is called, reuse the same key when possible #2846

[go_router] When replace is called, reuse the same key when possible #2846

Uh oh!

Conversation

ValentinVignal commented Nov 24, 2022

Pre-launch Checklist

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Nov 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarufHassan17 commented Dec 23, 2022

Uh oh!

ValentinVignal commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ValentinVignal commented Dec 23, 2022

Uh oh!

chunhtai commented Jan 4, 2023

Uh oh!

ValentinVignal commented Jan 9, 2023

Uh oh!

ValentinVignal commented Jan 9, 2023

Uh oh!

ValentinVignal commented Jan 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ValentinVignal commented Jan 17, 2023

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

[go_router] When `replace` is called, reuse the same key when possible #2846

[go_router] When `replace` is called, reuse the same key when possible #2846

ValentinVignal Nov 29, 2022 •

edited

Loading

ValentinVignal commented Dec 23, 2022 •

edited

Loading

ValentinVignal commented Jan 9, 2023 •

edited

Loading

chunhtai Feb 17, 2023 •

edited

Loading

chunhtai Feb 2, 2023 •

edited

Loading