Skip to content

[go_router_builder] Generate replace method in RouteExtension #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2023
Merged

[go_router_builder] Generate replace method in RouteExtension #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d40ca6b
[go_router_builder] pushReplacement method added
omensight Jan 5, 2023
35c59c5
Merge branch 'main' into main
omensight Feb 15, 2023
5c66229
[go_router_builder] pushReplacement method added to builder test input
omensight Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/go_router_builder/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.1.1

* Support for the generation of the pushReplacement method has been added.

## 1.1.0

* Supports default value for the route parameters.
Expand Down
33 changes: 33 additions & 0 deletions packages/go_router_builder/example/lib/all_types.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions packages/go_router_builder/example/lib/main.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions packages/go_router_builder/example/lib/simple_example.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/go_router_builder/lib/src/route_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ extension $_extensionName on $_className {
void go(BuildContext context) => context.go(location, extra: this);

void push(BuildContext context) => context.push(location, extra: this);

void pushReplacement(BuildContext context) =>
context.pushReplacement(location, extra: this);
}
''';

Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: go_router_builder
description: >-
A builder that supports generated strongly-typed route helpers for
package:go_router
version: 1.1.0
version: 1.1.1
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22

Expand Down
6 changes: 6 additions & 0 deletions packages/go_router_builder/test/test_inputs/_go_router_builder_test_input.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ extension $EnumParamExtension on EnumParam {
void go(BuildContext context) => context.go(location, extra: this);

void push(BuildContext context) => context.push(location, extra: this);

void pushReplacement(BuildContext context) =>
context.pushReplacement(location, extra: this);
}

const _$EnumTestEnumMap = {
Expand Down Expand Up @@ -138,6 +141,9 @@ extension $DefaultValueRouteExtension on DefaultValueRoute {
void go(BuildContext context) => context.go(location, extra: this);

void push(BuildContext context) => context.push(location, extra: this);

void pushReplacement(BuildContext context) =>
context.pushReplacement(location, extra: this);
}

T? _$convertMapValue<T>(
Expand Down