-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run scorecards only on pushes to main. #2546
Conversation
This is to prevent the workflow from failing when running in branches with no previous data to compare. It also adds the scorecard badge to the README file.
push: | ||
branches: [ main ] | ||
branches: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these just different syntax for the same thing? Or is the fix the removal of the empty entry above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not sure it the empty branch protection was causing this workflow to run on push of any branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I guess, it's just not clear to me that this will actually fix it.
If it does, we need the same change in flutter/plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd that we haven't seen this more often. Dependabot creates branches all the time that should be triggering this more often? (maybe?)
(Also, this will have to be merged with the submit-queue in red to attempt to fix it)
Yeah but dependabot is actually creating a PR in this case it was a direct push, should I disable that to make packages consistent with flutter/flutter and flutter/engine? |
I'm not aware of a reason we should have a different setup here than flutter/flutter and flutter/engine, so I'd be fine with aligning the configurations and seeing if anything breaks. |
No, I meant that dependabot creates branches in the repo to create their PRs, similar to the branch that was causing the error? Anyway, the Scorecard is now passing on master, yay! |
This is to prevent the workflow from failing when running in branches
with no previous data to compare.
It also adds the scorecard badge to the README file.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.