fix analysis warnings in imitation_game #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, weird that it didn't need this change: --- a/packages/imitation_game/bin/imitation_game.dart
+++ b/packages/imitation_game/bin/imitation_game.dart
@@ -5,8 +5,6 @@ import 'package:mustache/mustache.dart';
import 'package:imitation_game/README_template.dart';
import 'package:args/args.dart';
-// ignore_for_file: avoid_as
-
const int _port = 4040;
Future<String> _findIpAddress() async {
|
|
I suppose it is due to an external analyzer change. |
gaaclarke
approved these changes
Oct 23, 2020
|
@creativecreatorormaybenot yep, it would be nice if those changes were incorporated as commits too so we could catch it earlier. Here's another reason why having a mega-repository would be great (https://cacm.acm.org/magazines/2016/7/204032-why-google-stores-billions-of-lines-of-code-in-a-single-repository/fulltext). I just had to fix the tree the other day after someone else's commit, now Yegor fixed it for me, karma. |
|
I know. Monorepo FTW! I'm not sure what's up with |
|
Landing on red to (hopefully) fix the build. |
|
Filed flutter/flutter#68934 |
stuartmorgan
pushed a commit
to stuartmorgan/packages
that referenced
this pull request
Apr 30, 2021
stuartmorgan
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Use package http * delete test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the master branch build.
/cc @creativecreatorormaybenot