[pigeon] adds option for java output to have the Generated annotation #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. But I can't find the approval button on my UI. I may not have enough permission. |
stuartmorgan
requested changes
Jun 21, 2022
| /// Determines if the `javax.annotation.Generated` is used in the output. This | ||
| /// is false by default since that dependency isn't available in plugins by | ||
| /// default . | ||
| final bool? useGeneratedAnnotation; |
There was a problem hiding this comment.
Why not non-nullable and defaulting to false? It's not clear to me what null would mean that would be different from false.
There was a problem hiding this comment.
Null means the option hasn't been specified, thus use the default value. It was originally implemented as nonnull but it resulted in duplication of the default value. By keeping it undefined until it's actually used I have a single point of truth about what the default value is.
| test('parse args - java_use_generated_annotation', () { | ||
| final PigeonOptions opts = | ||
| Pigeon.parseArgs(<String>['--java_use_generated_annotation']); | ||
| expect(opts.javaOptions!.useGeneratedAnnotation, isTrue); |
There was a problem hiding this comment.
There should be a test that the default is actually false as well.
gaaclarke
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#105653
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.