Repository navigation
[cupertino_ui] Remove redundant null arguments in Completer.complete - #13008
Merged
Merged
Conversation
Prepares for flagging redundant null argument values in avoid_redundant_argument_values (dart-lang/sdk#59150).
github-actions
Bot
added
p: cupertino_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several test cases in packages/cupertino_ui/test/refresh_test.dart by replacing mockHelper.refreshCompleter.complete(null) with mockHelper.refreshCompleter.complete(). There are no review comments, and I have no feedback to provide.
dkwingsmt
added
the
autosubmit
11 tasks done
bkonyi
pushed a commit
to bkonyi/flutter
that referenced
this pull request
Oct 2, 2026
…utter#193718) This is work towards dart-lang/sdk#59150 The lint rule `avoid_redundant_argument_values` is being updated (https://dart-review.googlesource.com/c/sdk/+/491341) to also flag redundant `null` arguments passed to optional parameters whose default value is `null` (such as `Completer<void>.complete(null)`). Already merged "upstream" at flutter/packages#13008 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This was referenced Oct 5, 2026
ZhuJHua
pushed a commit
to ZhuJHua/flutter
that referenced
this pull request
Oct 6, 2026
…er#193840) flutter/packages@5620e65...951f2f7 2026-10-05 Hamidrezash1384@gmail.com [material_ui] Add scrollPadding property to DropdownMenuFormField (flutter/packages#12735) 2026-10-02 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 Motion template to use new gen_defaults (flutter/packages#13058) 2026-10-02 44747303+theprantadutta@users.noreply.github.com [cupertino_ui] Forward showDragHandle from showCupertinoSheet to CupertinoSheetRoute (flutter/packages#13011) 2026-10-02 105214765+HibaChamkhi@users.noreply.github.com [cupertino_ui] Fix CupertinoMagnifier focal point with custom size (flutter/packages#13029) 2026-10-02 katelovett@google.com [ci] Add material_ui and cupertino_ui to customer testing (flutter/packages#13114) 2026-10-02 36861262+QuncCccccc@users.noreply.github.com [material_ui] Add Material 3 Expressive migration skill (flutter/packages#12818) 2026-10-02 sethineelansh@gmail.com [video_player] Ignore late position updates after disposal (flutter/packages#12971) 2026-10-02 46639812+Gyeony95@users.noreply.github.com [material_ui] Remove unconditional dart:io import from about.dart (flutter/packages#12774) 2026-10-02 50643541+Mairramer@users.noreply.github.com [material_ui] Fix DropdownButtonFormField underline alignment at bottom (flutter/packages#12606) 2026-10-02 engine-flutter-autoroll@skia.org Roll Flutter from e89fd0a to d03768e (23 revisions) (flutter/packages#13111) 2026-10-02 dkwingsmt@users.noreply.github.com [material_ui] Migrate `Switch` API doc snippets to {@example} (batch 8) (flutter/packages#13052) 2026-10-02 45616602+NikhilKukreja26@users.noreply.github.com [url_launcher] Fix supportsCloseForLaunchMode to query close support (flutter/packages#12926) 2026-10-02 15619084+vashworth@users.noreply.github.com Redistribute iOS/macOS Suggested Reviewers (flutter/packages#13076) 2026-10-02 anilcan.cakir@gmail.com [image_picker] Subsample large images when resizing on Android (flutter/packages#13038) 2026-10-02 kevmoo@users.noreply.github.com [cupertino_ui] Remove redundant null arguments in Completer.complete (flutter/packages#13008) 2026-10-02 269567208+reidbaker-agent@users.noreply.github.com [repo] Update AGENTS.md with dependency allowance and versioning guidance (flutter/packages#12579) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work towards dart-lang/sdk#59150 (https://dart-review.googlesource.com/c/sdk/+/491341).
The
avoid_redundant_argument_valueslint rule is being updated to flag redundantnullargument values passed to optional nullable parameters with no default value (such asCompleter.complete([FutureOr<T>? value])).Pre-Review Checklist
[shared_preferences]///).