Skip to content

[two_dimensional_scrollables] Fix horizontal scrolled tree view hit testing #10977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MousyBusiness wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −2
Open

[two_dimensional_scrollables] Fix horizontal scrolled tree view hit testing #10977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaab1e7
fix: hit testing when horizontally scrolled
Feb 7, 2026
b5351da
Merge branch 'flutter:main' into main
MousyBusiness Feb 7, 2026
20d20be
[two_dimensional_scrollables] v0.3.9
Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/two_dimensional_scrollables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.9

* Fix hit testing issue when horizontally scrolled.
Copy link

@gemini-code-assist gemini-code-assist bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly fixes the hit testing issue, the PR is missing a regression test. As per the repository style guide (line 18), changes should be tested. Please add a test case that involves a horizontally scrolled TreeView to verify this fix and prevent future regressions.

References
  1. Code should be tested. This bug fix should be accompanied by a regression test. (link)

Copy link
Contributor

@Piinks Piinks Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, G! This is correct, we will need a test to verify this change works as expected and prevents future regressions.
Also, this changelog entry should mention the fix is to TreeView. There are a couple of different widgets in this package.


## 0.3.8

* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.
Expand Down
2 changes: 1 addition & 1 deletion packages/two_dimensional_scrollables/lib/src/tree_view/render_tree.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ class RenderTreeViewport extends RenderTwoDimensionalViewport {
}
final Rect rowRect =
parentData.paintOffset! &
Size(viewportDimension.width, row.size.height);
Size(row.size.width, row.size.height);
if (rowRect.contains(position)) {
result.addWithPaintOffset(
offset: parentData.paintOffset,
Expand Down
2 changes: 1 addition & 1 deletion packages/two_dimensional_scrollables/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: two_dimensional_scrollables
description: Widgets that scroll using the two dimensional scrolling foundation.
version: 0.3.8
version: 0.3.9
repository: https://github.com/flutter/packages/tree/main/packages/two_dimensional_scrollables
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+two_dimensional_scrollables%22+

Expand Down