Rebuild packages/animations/example to enable macOS #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domesticmouse
changed the title
|
How was this generated? Is this just deleting the |
goderbauer
reviewed
Feb 21, 2020
| @@ -37,12 +37,12 @@ android { | |||
| } | |||
|
|
|||
| defaultConfig { | |||
| applicationId "dev.flutter.packages.animations.example" | |||
There was a problem hiding this comment.
Here and elsewhere: we should keep the more specific application ids.
There was a problem hiding this comment.
Reverted this change, by re-running flutter create --org=dev.flutter.packages.animations .
|
On cirrus we currently only check that ios and android continue to build. We probably need to add checks for other platforms as well if we add them. Otherwise this can just break without us noticing... |
|
I know nothing about how to setup Cirrus for web and macOS. Fwiw, the web version is currently broken. /cc @kevmoo for clues on what is required to fix all of this =) |
|
I have no experience w/ Cirrus. Wish I did, though!
…On Mon, Feb 24, 2020 at 3:07 PM Brett Morgan ***@***.***> wrote:
I know nothing about how to setup Cirrus for web and macOS. Fwiw, the web
version is currently broken.
/cc @kevmoo <https://github.com/kevmoo> for clues on what is required to
fix all of this =)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105?email_source=notifications&email_token=AAAEFCTVCQ7XPYYYSKBIPKDRERHM3A5CNFSM4KY3UA5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZ4GGY#issuecomment-590594843>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCRRDWRADQV3HMN5MSDRERHM3ANCNFSM4KY3UA5A>
.
|
stuartmorgan
pushed a commit
to stuartmorgan/packages
that referenced
this pull request
Apr 30, 2021
stuartmorgan
pushed a commit
that referenced
this pull request
Oct 31, 2024
Avoids overdraw where possible for fills.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.