[pigeon] Update analyzer version

[dgyurov]

Adds compatibility with version 8 of the analyzer package. I did not update to version 9 of the analyzer directly, because I think it's sensible to adopt 8 and have a release of pigeon that conforms to 8 first. This will give the chance to consuming projects to upgrade analyzer versions at their own pace. As as follow up PR, I can also work on updating to version 9 for a future release.

Fixes flutter/flutter#175432

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request updates the pigeon package to add compatibility with version 8 of the analyzer package. The changes include updating the package version to 26.0.3 in pubspec.yaml and lib/src/generator_tools.dart, updating the analyzer dependency constraint, and adding a corresponding entry to the CHANGELOG.md. The changes are consistent and correctly implemented.

[stuartmorgan-g]

LGTM, thanks!

[stuartmorgan-g]

This will give the chance to consuming projects to upgrade analyzer versions at their own pace.

This is always true of expanding a range, as the PR currently does. Does this mean compatibility with 9.x requires changes that break compatibility with 6-8?

[dgyurov]

This will give the chance to consuming projects to upgrade analyzer versions at their own pace.

This is always true of expanding a range, as the PR currently does. Does this mean compatibility with 9.x requires changes that break compatibility with 6-8?

I think the update to 9.x will be fairly straightforward as well. There is however one hurdle:

analyzer 8.0.0 -> introduces NamedType.name and deprecates NamedType.name2
analyzer 9.0.0 -> removes NamedType.name2

It seems that NamedType.name2 is used at couple of places in pigeon_lib_internal.dart. I believe that adopting 9.x, will require to move the minimum version to 8.0.0. It's a little bit unfortunate. The analyzer package is a very special dependency, because it's tightly coupled with Dart.

[stuartmorgan-g]

Ah, I missed that there was one of those rename cycles in 8+9. We did indeed need to drop old versions last time, so it definitely makes sense to do that separately.

[tarrinneal]

Thanks for doing this!