-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[webview_flutter_wkwebview] Fixes crash when running WKNavigationResponse tests on Xcode 26
#10316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WKNavigationResponse tests on Xcode 26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a crash that occurs during testing by introducing a singleton pattern for TestNavigationResponse. By using a static instance, it prevents premature deallocation of WKNavigationResponse objects within the test environment, which was causing the crash. The changes are correctly applied across the test files.
To align with the repository's contribution guidelines, please update the pull request title to include the package name (e.g., [webview_flutter_wkwebview] Fix crash in tests) and fill out the PR description with the necessary details, including the checklist and a link to the issue this PR resolves.
I have one suggestion to make the singleton implementation more robust.
| static let instance = TestNavigationResponse() | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fully enforce the singleton pattern and prevent accidental creation of new TestNavigationResponse instances elsewhere in the tests, it's a good practice to make the initializer private. This will prevent reintroducing the deallocation crash in the future.
static let instance = TestNavigationResponse()
private override init() {
super.init()
}
LongCatIsLooong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is only deferring the crash to when the program terminates (instead of at the end of the test), now that the instance is made static.
The documentation says
You don’t create WKNavigationResponse objects directly.
So I guess that explains why it is tricky to create WKNavigationResponse mocks. Someone actually had the exact same crash stacktrace here: https://developer.apple.com/forums/thread/804615, and they said they were able to workaround the crash (without preventing the mocks from deallocating).
…igationResponse` tests on Xcode 26 (flutter/packages#10316)
flutter/packages@8cb4903...d39e481 2025-12-04 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes crash that occurs when an object that is removed from the instance manager calls to Dart (flutter/packages#10552) 2025-12-04 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes error from constructor parameter sharing name with attached field for a ProxyApi (flutter/packages#10541) 2025-12-04 okorohelijah@google.com fix[image_picker_ios]: Prevent transcoding on video selection (flutter/packages#10559) 2025-12-04 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes crash when running `WKNavigationResponse` tests on Xcode 26 (flutter/packages#10316) 2025-12-03 15619084+vashworth@users.noreply.github.com Redistribute iOS CODEOWNERS (flutter/packages#10520) 2025-12-03 stuartmorgan@google.com [url_launcher] Update for UIScene compatibility (flutter/packages#10549) 2025-12-03 engine-flutter-autoroll@skia.org Roll Flutter from e274574 to 69d8710 (5 revisions) (flutter/packages#10558) 2025-12-03 engine-flutter-autoroll@skia.org Roll Flutter from 5545bb3 to e274574 (17 revisions) (flutter/packages#10554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#179451) flutter/packages@8cb4903...d39e481 2025-12-04 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes crash that occurs when an object that is removed from the instance manager calls to Dart (flutter/packages#10552) 2025-12-04 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes error from constructor parameter sharing name with attached field for a ProxyApi (flutter/packages#10541) 2025-12-04 okorohelijah@google.com fix[image_picker_ios]: Prevent transcoding on video selection (flutter/packages#10559) 2025-12-04 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes crash when running `WKNavigationResponse` tests on Xcode 26 (flutter/packages#10316) 2025-12-03 15619084+vashworth@users.noreply.github.com Redistribute iOS CODEOWNERS (flutter/packages#10520) 2025-12-03 stuartmorgan@google.com [url_launcher] Update for UIScene compatibility (flutter/packages#10549) 2025-12-03 engine-flutter-autoroll@skia.org Roll Flutter from e274574 to 69d8710 (5 revisions) (flutter/packages#10558) 2025-12-03 engine-flutter-autoroll@skia.org Roll Flutter from 5545bb3 to e274574 (17 revisions) (flutter/packages#10554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter/flutter#173326
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3