Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 45bcc3210fcc
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0f1fd493b893
Choose a head ref
  • 4 commits
  • 33 files changed
  • 3 contributors

Commits on Dec 9, 2024

  1. [google_sign_in] Clean up Java code (#8241) 

    Removes the legacy public native interface to the sign-in plugin, which was inherently linked to raw method channels (which we no longer use) and the structure of the Google Sign-In native SDK (which is deprecated), so we don't want to continue supporting.

I (unsurprisingly, as native->native plugin dependencies are very rare) can't find any evidence that any public plugin has ever directly used this Java code. The original use case this was added for was internal, and no longer exists (see b/158361263).

The test file being deleted is specific to the legacy interface. There is already an almost-exact duplicate of that test file that tests the Pigeon interface.
    @stuartmorgan-g
    stuartmorgan-g authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    ebe5367 View commit details
    Browse the repository at this point in the history

  2. [path_provider] Clean up Java code (#8240) 

    Minor cleanup in the native implementation code:
- Removes a utility to map from index integers to directories, which hasn't been used since the Pigeon conversion but was accidentally left.
- Inlines all the implementations of path getters; many methods were pointlessly delegating their implementation to another private method, which is a relic of the pre-Pigeon structure.

All of the method implementations were moved without any changes.
    @stuartmorgan-g
    stuartmorgan-g authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    9f6d599 View commit details
    Browse the repository at this point in the history

  3. [google_adsense] Tighten exports and docs. (#8233) 

    * **Breaking changes**: Reshuffles API exports:
  * Removes the `adUnit` method, and instead exports the `AdUnitWidget` directly.
  * Renames `experimental/google_adsense` to `experimental/ad_unit_widget.dart`.
  * Removes the `AdStatus` and `AdUnitParams` exports.
  * Removes the "stub" files, so this package is now web-only and must be used
    through a conditional import.
* Tweaks several documentation pages to remove references to internal APIs.
* Splits tests to reflect the new code structure.

## Issue

* Continuation of: #6871
* Part of: flutter/flutter#40376
    @ditman
    ditman authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    2dc8b98 View commit details
    Browse the repository at this point in the history

  4. [dependabot] Generalizes dependabot commit message prefix (#8255) 

    Changes dependabot commit message prefix from "[gradle]" to "[dependabot]" since dependabot handles more than Gradle updates.

Also updates dependabot configuration docs link since the one included didn't work for me.
    @camsim99
    camsim99 authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    0f1fd49 View commit details
    Browse the repository at this point in the history
Loading