RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

WasserEsser · 2022-01-14T02:23:28Z

RenderIndexedStack did not override debugDescribeProperties and thus all childrens were marked as onstage, resulting in the behaviour described in #96581.

Inspired by @Albert221, this fixes #96581.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

packages/flutter/lib/src/rendering/stack.dart

jacob314

Thanks for fixing this!

packages/flutter/lib/src/rendering/stack.dart

jacob314

packages/flutter/lib/src/rendering/stack.dart

jacob314

goderbauer

LGTM

fluttergithubbot · 2022-02-07T22:25:16Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ebugDescribeProperties (flutter/flutter#96639)

…ribeProperties (flutter#96639)

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 14, 2022

WasserEsser changed the title ~~Mark invisible children as offstage in debugDescribeProperties~~ RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties Jan 14, 2022

WasserEsser marked this pull request as ready for review January 14, 2022 02:58

jacob314 reviewed Jan 14, 2022

View reviewed changes

packages/flutter/lib/src/rendering/stack.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jan 14, 2022

View reviewed changes

jacob314 reviewed Jan 18, 2022

View reviewed changes

packages/flutter/lib/src/rendering/stack.dart Outdated Show resolved Hide resolved

jacob314 approved these changes Jan 18, 2022

View reviewed changes

jacob314 reviewed Jan 26, 2022

View reviewed changes

packages/flutter/lib/src/rendering/stack.dart Outdated Show resolved Hide resolved

jacob314 approved these changes Feb 2, 2022

View reviewed changes

goderbauer approved these changes Feb 2, 2022

View reviewed changes

goderbauer added the waiting for tree to go green label Feb 2, 2022

WasserEsser force-pushed the b96581 branch from 966ece6 to 354eb70 Compare February 7, 2022 19:58

Mark invisible children as offstage in debugDescribeProperties

8dbd319

WasserEsser force-pushed the b96581 branch from 53ea782 to 8dbd319 Compare February 7, 2022 20:06

WasserEsser added 3 commits February 7, 2022 21:06

Trigger CI

8d33bf4

Trigger CI

317c382

Trigger CI

256fd3d

fluttergithubbot removed the waiting for tree to go green label Feb 7, 2022

goderbauer added the waiting for tree to go green label Feb 7, 2022

fluttergithubbot merged commit 36a8f0f into flutter:master Feb 8, 2022

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from 185bc093e04b to 36a8f0f2ae01 (47 revisions) flutter/packages#715

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

d0a8f37

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from 185bc093e04b to a6504ead31d6 (48 revisions) flutter/packages#716

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

7e96664

…ebugDescribeProperties (flutter/flutter#96639)

WasserEsser deleted the b96581 branch February 8, 2022 00:47

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from 185bc093e04b to 26d4e92750a7 (49 revisions) flutter/packages#717

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

3eb86a7

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from 185bc093e04b to 93a1b7a577dd (50 revisions) flutter/packages#718

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

8ba71a1

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from f483b7d80831 to 4f975cbe2fc9 (36 revisions) flutter/plugins#4765

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

7253967

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from f483b7d80831 to 4f975cbe2fc9 (36 revisions) flutter/packages#745

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

c682b01

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 4f975cbe2fc9 (36 revisions) flutter/plugins#4766

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

5004368

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 9eb94c59b8cd (38 revisions) flutter/plugins#4767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

d176582

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 63f48d1ff8db (39 revisions) flutter/plugins#4768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

2e330f4

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 3bdea6bb925a (40 revisions) flutter/plugins#4769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

8c80cec

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to ae3f99c98af7 (41 revisions) flutter/plugins#4770

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

0c5310c

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to d2853dce6c14 (43 revisions) flutter/plugins#4771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

e75b99c

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 3669e3669a89 (44 revisions) flutter/plugins#4772

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

55dfcf4

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 499e900e3952 (45 revisions) flutter/plugins#4773

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

00e1939

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to c54a27dc8790 (46 revisions) flutter/plugins#4774

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

6162c59

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 312085a19a0f (47 revisions) flutter/plugins#4775

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

475ce05

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to ca647d1e9a5d (48 revisions) flutter/plugins#4776

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

01349df

…ebugDescribeProperties (flutter/flutter#96639)

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to bb3275b9340f (51 revisions) flutter/plugins#4778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…

c7000d8

…ebugDescribeProperties (flutter/flutter#96639)

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022

RenderIndexedStack - Mark invisible children as offstage in debugDesc…

e8c7e20

…ribeProperties (flutter#96639)

danagbemava-nc mentioned this pull request Jun 20, 2022

Inspector Select Widget Mode select wrong Widget inside IndexedStack #106219

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

Uh oh!

WasserEsser commented Jan 14, 2022 •

edited

Loading

Uh oh!

Uh oh!

jacob314 left a comment

Uh oh!

Uh oh!

jacob314 left a comment

Uh oh!

Uh oh!

jacob314 left a comment

Uh oh!

goderbauer left a comment

Uh oh!

fluttergithubbot commented Feb 7, 2022

Uh oh!

Uh oh!

RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

Uh oh!

Conversation

WasserEsser commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented Feb 7, 2022

Uh oh!

Uh oh!

WasserEsser commented Jan 14, 2022 •

edited

Loading