Skip to content

Update packages #92924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 5, 2021
Merged

Update packages #92924

merged 8 commits into from
Nov 5, 2021

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Nov 2, 2021

  • Updates all packages with flutter update-packages --force-upgrade.
  • Removes pinning of package:test (issue is resolved)
  • Removes pedantic from the package allow list

Pulls in the fix for dart-lang/test#1505

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jakemac53 jakemac53 requested a review from Piinks as a code owner November 2, 2021 18:10
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 2, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@Hixie
Copy link
Contributor

Hixie commented Nov 2, 2021

test-exempt: only rolls dependencies

@jakemac53
Copy link
Contributor Author

I am seeing this failure https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20flutter_plugins/16597/overview which looks like a timeout, but I don't have any idea how to go about trying to diagnose that?

It appears to be timing out on a flutter pub get in the android_intent package?

@jakemac53
Copy link
Contributor Author

Ok, it looks like the issue is a version lock due to the android_intent package depending on an old version of build_runner. I will send a separate PR to update that.

@jakemac53
Copy link
Contributor Author

jakemac53 commented Nov 3, 2021

It looks like this is now failing due to some references to package:pedantic in the analysis options files in some plugins.

In particular the issue seems to be with the analysis_options_legacy.yaml file at the root of the flutter_plugins repo. I am not sure how this ever worked as it has no pubspec.yaml to pull in pedantic.

@jakemac53
Copy link
Contributor Author

This should be ready to land now

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit a4fa2af into flutter:master Nov 5, 2021
@jakemac53 jakemac53 deleted the update-packages branch November 5, 2021 19:10
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants