Adds Flutter GCM package #913
Conversation
|
|
||
| /// Service exposed to Flutter apps that implements a subset of the GCM API. | ||
| /// | ||
| /// This library will probably be moved into a separate package eventually. |
There was a problem hiding this comment.
We should probably open a separate github repo for "third party services" and have this be one of them. @collinjackson has a similar issue with his work. cc @abarth.
There was a problem hiding this comment.
(it doesn't have to be now, but it should be really soon. Having Google-specific services in the Flutter repo gives a very mixed message about what Flutter is. We want to make sure other companies and developers understand that they are peers, not subordinate in any way.)
There was a problem hiding this comment.
Agreed. Our plan is to put them in the main repo first to see what is needed, then move them to a separate repo.
| sky_services: 0.0.75 | ||
| # sky_services: 0.0.73 | ||
| sky_services: | ||
| path: ../../../engine/src/out/android_Debug/gen/dart-pkg/sky_services |
There was a problem hiding this comment.
I don't think you want to check this in
|
LGTM once the sky_services dependency is fixed and tests pass |
mpcomplete
force-pushed
the
gcm
branch
3 times, most recently
from
ad61334 to
c8f6344
Compare
No description provided.