Repository navigation
[Reland] Skip staging test update to cocoon in test runner - #89137
Merged
fluttergithubbot merged 1 commit intoAug 30, 2021
Merged
Conversation
flutter-dashboard
Bot
added
the
c: contributor-productivity
CaseyHillers
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reland of #88835 and #88908
The reason for the revert of those two PRs is lock contention when writing multiple tasks results to GCS. With flutter/packages#444, devicelab task metrics have been uploaded to GCS in separate test json files successfully. (No single error happens in recent >10 commits ~ 1000 tests).
This PR removes the try catch block to highlight
metric uploadstep error if any. It also adds logic to skip test update to cocoon for staging tests.