Skip to content

Revert "Fixes listview shrinkwrap and hidden semantics node gets upda… - #88886

Merged
chunhtai merged 1 commit into
flutter:masterfrom
chunhtai:issues/84719-revert
Aug 25, 2021
Merged

chunhtai merged 1 commit into
flutter:masterfrom
chunhtai:issues/84719-revert

Conversation

@chunhtai

Copy link
Copy Markdown
Contributor

causes internal test failure

#84719

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 25, 2021
@google-cla google-cla Bot added the cla: yes label Aug 25, 2021

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
chunhtai merged commit 527d868 into flutter:master Aug 25, 2021
@dnfield

dnfield commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

FWIW, I think the internal screen diffs that "failed" because of this actually look more reasonable now, but I'm not 100% sure - we should talk to the owners about it.

@dnfield

dnfield commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

(reverting while we do that is of course a good idea :)

@chunhtai

chunhtai commented Aug 25, 2021 •

Copy link
Copy Markdown
Contributor Author

I dont know what their ui looks like, some of them seems to render more items than the origin. I have to look into the customers' code to be sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants