Skip to content

[flutter_conductor] Push correct revision to mirror remote from conductor - #88607

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
chris-forks:conductor-bug
Aug 20, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
chris-forks:conductor-bug

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Aug 20, 2021 •

Copy link
Copy Markdown
Contributor

Issue

fixes #88606

When pushing the local working branch of the Flutter framework to the conductor user's mirror remote, it pushes the wrong commit hash, because it captures this hash before applying the engine roll commit.

Solution

Rather than querying the HEAD commit and explicitly pushing that revision to the remote, simple use HEAD in the git push command.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 20, 2021
@google-cla google-cla Bot added the cla: yes label Aug 20, 2021
@christopherfujino
christopherfujino marked this pull request as ready for review August 20, 2021 21:24

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_conductor] conductor pushes commit before engine roll

3 participants