Skip to content

Reland "update ScrollMetricsNotification (#87421)" - #87818

Merged
chunhtai merged 2 commits into
flutter:masterfrom
chunhtai:reland-notification
Aug 9, 2021
Merged

chunhtai merged 2 commits into
flutter:masterfrom
chunhtai:reland-notification

Conversation

@chunhtai

@chunhtai chunhtai commented Aug 6, 2021

Copy link
Copy Markdown
Contributor

This reverts commit 0f465e5.

previous pr broke internal tests. The test will be fixed by cl/388794349

blocked on cl/388794349

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Aug 6, 2021
@google-cla google-cla Bot added the cla: yes label Aug 6, 2021
@chunhtai

chunhtai commented Aug 6, 2021

Copy link
Copy Markdown
Contributor Author

cc @Piinks @xu-baolin

@xu-baolin

Copy link
Copy Markdown
Member

Some tests failed because of multiple assertions reported.

I am surprised that the test did not report an error when it first landing.

@chunhtai

chunhtai commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

7bbcdc239b changed the way the error is reported

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the failing tests reveal a condition that should be added to the changes from 7bbcdc2
If more than one position is attached to the controller, then RawScrollbarState._shouldUpdatePainter should return false. The failing checks appear to be from the gallery integration tests.
@chunhtai do you want to add that here? Or should I add it in a separate change?

@chunhtai

chunhtai commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

@Piinks I will add it in this pr

@chunhtai
chunhtai force-pushed the reland-notification branch from 828a5c5 to 9fc17cf Compare August 9, 2021 19:29
@chunhtai
chunhtai requested a review from Piinks August 9, 2021 20:00

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

///
/// This should not be mutated directly. [ScrollPosition] objects can be added
/// and removed using [attach] and [detach].
@protected

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo this is a very exciting change. There are so many work arounds for this that we could clean up. :)

@chunhtai

chunhtai commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

Test run https://fusion2.corp.google.com/presubmit/tap/389684836/OCL:389684836:BASE:389709544:1628540380244:3438f481

one golden failure that is a pretty minor diff and is probably the correct change merging this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants