Skip to content

Don't set the SplashScreenDrawable for new projects - #87619

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jiahaog:remove-splash-manifest
Aug 5, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
jiahaog:remove-splash-manifest

Conversation

@jiahaog

@jiahaog jiahaog commented Aug 4, 2021

Copy link
Copy Markdown
Member

This is obsolete after #85292 was fixed. The preDraw listener returns false, keeping the initial android:windowBackground on screen until Flutter shows the first frame.

<!-- Show a splash screen on the activity. Automatically removed when
Flutter draws its first frame -->
<item name="android:windowBackground">@drawable/launch_background</item>

Related issue: #86955

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 4, 2021
@google-cla google-cla Bot added the cla: yes label Aug 4, 2021
@jiahaog
jiahaog marked this pull request as ready for review August 4, 2021 04:12
@jiahaog
jiahaog requested a review from blasten August 4, 2021 04:12

@blasten blasten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants