Skip to content

Add Cupterino button animation test - #87535

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:cupertino-button-test
Aug 3, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:cupertino-button-test

Conversation

@jmagman

@jmagman jmagman commented Aug 2, 2021

Copy link
Copy Markdown
Member

Add test in preparation for #87139

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@jmagman jmagman added framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages labels Aug 2, 2021
@jmagman jmagman self-assigned this Aug 2, 2021
@google-cla google-cla Bot added the cla: yes label Aug 2, 2021

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM - more tests, more better. :)

@fluttergithubbot
fluttergithubbot merged commit d1eff7f into flutter:master Aug 3, 2021
@jmagman
jmagman deleted the cupertino-button-test branch August 3, 2021 17:40
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants