Repository navigation
Allow for customizing and theming of extended FAB content padding - #87062
Merged
Merged
Conversation
flutter-dashboard
Bot
added
p: material_ui
rami-a
changed the title
clocksmith
reviewed
Jul 26, 2021
| const Widget width16 = SizedBox(width: 16.0); | ||
| final EdgeInsetsGeometry padding = extendedPadding | ||
| ?? floatingActionButtonTheme.extendedPadding | ||
| ?? (child != null && isExtended ? const EdgeInsetsDirectional.only(start: 16.0, end: 20.0) : const EdgeInsetsDirectional.only(start: 20.0, end: 20.0)); |
Contributor
There was a problem hiding this comment.
It might be better to put the conditional in the start field, losing 2 consts for 1 non const EdgeInsetsDirectional?
clocksmith
reviewed
Jul 26, 2021
| padding: padding, | ||
| child: Row( | ||
| mainAxisSize: MainAxisSize.min, | ||
| children: child == null |
Contributor
There was a problem hiding this comment.
This can be reduced to an array with if conditionals inside
clocksmith
approved these changes
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a parameter to the extended FAB constructor (and the FAB theme) to allow for the customization of the content's padding for the extended FAB.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.