Repository navigation
Update args package - #86880
Merged
Merged
Update args package#86880
Conversation
jonahwilliams
left a comment
Contributor
There was a problem hiding this comment.
LGTM!!
(Will keep an eye out for test failures, but should be OK)
Contributor
Author
|
Should I actually mark this as closing #74521? It does seem like consensus was reached around this solution. |
Contributor
|
Yes, I think we might have another one about typos, one sec |
Contributor
|
maybe this one too: #46009 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version provides suggestions for alternate commands when an unrecognized command is used.
Fixes #74521
Fixes #46009
Example output is as follows:
@jonahwilliams I noticed there seems to be a fair bit of whitespace here between the suggestions and the usage footer, let me know if you think that is an issue. I am not sure if this is expected.
This feature is tested in the args package, I don't think we need additional tests here. It may affect integration tests if there are any for this case, in which case I can update them.
Pre-launch Checklist
///).