Skip to content

Update args package - #86880

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
jakemac53:update-packages
Jul 22, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
jakemac53:update-packages

Conversation

@jakemac53

@jakemac53 jakemac53 commented Jul 22, 2021 •

Copy link
Copy Markdown
Contributor

This version provides suggestions for alternate commands when an unrecognized command is used.

Fixes #74521
Fixes #46009

Example output is as follows:

image

@jonahwilliams I noticed there seems to be a fair bit of whitespace here between the suggestions and the usage footer, let me know if you think that is an issue. I am not sure if this is expected.

This feature is tested in the args package, I don't think we need additional tests here. It may affect integration tests if there are any for this case, in which case I can update them.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@jakemac53
jakemac53 requested a review from jonahwilliams July 22, 2021 16:46
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 22, 2021
@google-cla google-cla Bot added the cla: yes label Jul 22, 2021

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

(Will keep an eye out for test failures, but should be OK)

@jakemac53

Copy link
Copy Markdown
Contributor Author

Should I actually mark this as closing #74521? It does seem like consensus was reached around this solution.

@jonahwilliams

Copy link
Copy Markdown
Contributor

Yes, I think we might have another one about typos, one sec

@jonahwilliams

Copy link
Copy Markdown
Contributor

maybe this one too: #46009 ?

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit fdb80f9 into flutter:master Jul 22, 2021
@jakemac53
jakemac53 deleted the update-packages branch July 22, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commands shouldn't be case sensitive Make flutter analyse print error suggesting flutter analyze (spelling)

3 participants