Skip to content

Add thumb color customization to CupertinoSwitch - #86775

Merged
fluttergithubbot merged 4 commits into
flutter:masterfrom
sunyujia-rakuten:cupertino-switch-thumb-color
Jul 28, 2021
Merged

fluttergithubbot merged 4 commits into
flutter:masterfrom
sunyujia-rakuten:cupertino-switch-thumb-color

Conversation

@sunyujia-rakuten

@sunyujia-rakuten sunyujia-rakuten commented Jul 21, 2021 •

Copy link
Copy Markdown
Contributor

Description

When using the CupertinoSwitch allow to set the thumb color.

This fixed the following issue: #86774

Tests

I added the following tests:

  • A test which confirms that the CupertinoSwitch.thumbColor is set
  • A test which confirms that the CupertinoSwitch.thumbColor is using default

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jul 21, 2021
@google-cla google-cla Bot added the cla: yes label Jul 21, 2021
@skia-gold

Copy link
Copy Markdown

Gold has detected about 2 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/86775

@sunyujia-rakuten sunyujia-rakuten changed the title Add thumb color customization to CupertinoSwich Add thumb color customization to CupertinoSwitch Jul 21, 2021
Comment thread packages/flutter/lib/src/cupertino/switch.dart Outdated
Comment thread packages/flutter/test/cupertino/switch_test.dart Outdated
Comment thread packages/flutter/test/cupertino/switch_test.dart Outdated
@google-cla

google-cla Bot commented Jul 23, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no and removed cla: yes labels Jul 23, 2021
@LongCatIsLooong

Copy link
Copy Markdown
Contributor

6a6c34d LGTM but you might need to remove the irrelevant commits.

@sunyujia-rakuten

Copy link
Copy Markdown
Contributor Author

6a6c34d LGTM but you might need to remove the irrelevant commits.

yeah my bad

@google-cla google-cla Bot added cla: yes and removed cla: no labels Jul 23, 2021

@LongCatIsLooong LongCatIsLooong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@sunyujia-rakuten

sunyujia-rakuten commented Jul 28, 2021 •

Copy link
Copy Markdown
Contributor Author

LGTM. Thanks for contributing!

Hi , @LongCatIsLooong . I don't remember when i requested a review from @jmagman for this PR . Is there anything else I need to do?

@jmagman

jmagman commented Jul 28, 2021

Copy link
Copy Markdown
Member

Is there anything else I need to do?

This needed the waiting for tree to go green label added to merge. Added the label, should go once the tree reopens.

@sunyujia-rakuten

sunyujia-rakuten commented Jul 28, 2021 •

Copy link
Copy Markdown
Contributor Author

This needed the waiting for tree to go green label added to merge. Added the label, should go once the tree reopens.

Okay,Thanks!

@fluttergithubbot
fluttergithubbot merged commit 10152db into flutter:master Jul 28, 2021
@sunyujia-rakuten
sunyujia-rakuten deleted the cupertino-switch-thumb-color branch July 29, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants