Repository navigation
[flutter_tools] let the logger know about machine mode - #86116
Merged
fluttergithubbot merged 2 commits intoJul 12, 2021
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
Contributor
Author
|
FYI @Hixie on linux testing failure: |
Contributor
opened issue #86192, since I also saw this. |
Hixie
reviewed
Jul 9, 2021
| (args.contains('--machine') && args.contains('attach')); | ||
| final bool machine = args.contains('--machine'); | ||
| final bool runMachine = (machine && args.contains('run')) || | ||
| (machine && args.contains('attach')); |
Contributor
There was a problem hiding this comment.
this won't work. Consider for example "flutter create --machine --org run attach".
Contributor
There was a problem hiding this comment.
This is true. Also, this PR doesn't change this behavior.
jonahwilliams
pushed a commit
that referenced
this pull request
Jul 13, 2021
This reverts commit 53d8cba.
jonahwilliams
pushed a commit
that referenced
this pull request
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to better support machine mode, the loggers need to be aware of it - so that they can allow calling code to elide prompts or avoid displaying messages that aren't reasonable to JSON format.
Start of the work towards #80993