Skip to content

Avoid iOS app with extension checks that fail on M1 ARM Macs - #85087

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:extension-arm
Jun 23, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:extension-arm

Conversation

@jmagman

@jmagman jmagman commented Jun 23, 2021

Copy link
Copy Markdown
Member

Xcode has slightly different build settings for an iOS app with a watch companion on an ARM Mac than on x86_64 Mac. The simulator is already being validated by running unit tests, so stick with validating architectures for physical devices.

Fixes #82402

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 23, 2021
@jmagman jmagman self-assigned this Jun 23, 2021
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 23, 2021
@google-cla google-cla Bot added the cla: yes label Jun 23, 2021
@jmagman jmagman changed the title Avoid iOS app with extension checks that fail on M1 Avoid iOS app with extension checks that fail on M1 ARM Macs Jun 23, 2021

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 67aee9a into flutter:master Jun 23, 2021
@jmagman
jmagman deleted the extension-arm branch June 23, 2021 17:25
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ios_app_with_extensions_test fails on ARM M1 mac

3 participants